Minor.

metal/cloud.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"slices"
 	"strings"
 
 	metalgo "github.com/metal-stack/metal-go"
@@ -117,6 +118,10 @@ func (c *cloud) Initialize(clientBuilder cloudprovider.ControllerClientBuilder,
 	clusterID := os.Getenv(constants.MetalClusterIDEnvVar)
 	loadbalancerType := os.Getenv(constants.Loadbalancer)
 
+	if !slices.Contains([]string{"cilium", "metallb", ""}, loadbalancerType) {
+		klog.Fatalf("only cilium or metallb load balancer types are supported")
+	}
+
 	k8sClientSet := clientBuilder.ClientOrDie("cloud-controller-manager")
 	k8sRestConfig, err := clientBuilder.Config("cloud-controller-manager")
 	if err != nil {

pkg/controllers/loadbalancer/addresspool.go

@@ -18,7 +18,7 @@ type AddressPool struct {
 	CIDRs      []string `json:"addresses,omitempty" yaml:"addresses,omitempty"` // It is assumed that only host addresses (/32 for ipv4 or /128 for ipv6) are used.
 }
 
-func NewBGPAddressPool(name string) *AddressPool {
+func newBGPAddressPool(name string) *AddressPool {
 	return &AddressPool{
 		Name:       name,
 		Protocol:   bgpProtocol,
@@ -56,7 +56,3 @@ func (pool *AddressPool) appendIP(ip string) error {
 	pool.CIDRs = append(pool.CIDRs, cidr)
 	return nil
 }
-
-func (pool *AddressPool) String() string {
-	return fmt.Sprintf("%s (%s): %v", pool.Name, pool.Protocol, pool.CIDRs)
-}

pkg/controllers/loadbalancer/config.go

@@ -67,7 +67,7 @@ func (cfg *Config) computePeers(nodes []v1.Node) error {
 			return err
 		}
 
-		peer, err := NewPeer(n, asn)
+		peer, err := newPeer(n, asn)
 		if err != nil {
 			klog.Warningf("skipping peer: %v", err)
 			continue
@@ -102,7 +102,7 @@ func (cfg *Config) getOrCreateAddressPool(poolName string) *AddressPool {
 		}
 	}
 
-	pool := NewBGPAddressPool(poolName)
+	pool := newBGPAddressPool(poolName)
 	cfg.AddressPools = append(cfg.AddressPools, pool)
 
 	return pool

pkg/controllers/loadbalancer/loadbalancer.go

@@ -350,3 +350,12 @@ func (l *LoadBalancerController) updateLoadBalancerConfig(ctx context.Context, n
 	}
 	return nil
 }
+
+func NodeAddress(node v1.Node) (string, error) {
+	for _, a := range node.Status.Addresses {
+		if a.Type == v1.NodeInternalIP {
+			return a.Address, nil
+		}
+	}
+	return "", fmt.Errorf("unable to determine node address")
+}

pkg/controllers/loadbalancer/peer.go

@@ -1,8 +1,6 @@
 package loadbalancer
 
 import (
-	"fmt"
-
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -14,7 +12,7 @@ type Peer struct {
 	NodeSelector metav1.LabelSelector `json:"node-selectors,omitempty" yaml:"node-selectors,omitempty"`
 }
 
-func NewPeer(node v1.Node, asn int64) (*Peer, error) {
+func newPeer(node v1.Node, asn int64) (*Peer, error) {
 	hostname := node.GetName()
 
 	matchExpression := metav1.LabelSelectorRequirement{
@@ -43,12 +41,3 @@ func NewPeer(node v1.Node, asn int64) (*Peer, error) {
 		},
 	}, nil
 }
-
-func NodeAddress(node v1.Node) (string, error) {
-	for _, a := range node.Status.Addresses {
-		if a.Type == v1.NodeInternalIP {
-			return a.Address, nil
-		}
-	}
-	return "", fmt.Errorf("unable to determine node address")
-}