Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size suggestion from machines #469

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Size suggestion from machines #469

merged 7 commits into from
Oct 12, 2023

Conversation

m1kepeter
Copy link
Contributor

closes #254

@m1kepeter m1kepeter requested a review from a team as a code owner September 26, 2023 12:43
@m1kepeter m1kepeter requested a review from Gerrit91 September 26, 2023 12:43
Gerrit91
Gerrit91 reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small typo, rest looks good!

cmd/metal-api/internal/service/size-service.go Outdated Show resolved Hide resolved
@Gerrit91
Copy link
Contributor

Needs spec-regeneration.

@Gerrit91 Gerrit91 merged commit 66cc986 into metal-stack:master Oct 12, 2023
1 of 2 checks passed
@Gerrit91 Gerrit91 mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 approved these changes

@majst01 majst01 majst01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to suggest size from machine
3 participants
@m1kepeter @Gerrit91 @majst01