Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grpc boot service #279

Merged
merged 44 commits into from
Jun 10, 2022
Merged

Grpc boot service #279

merged 44 commits into from
Jun 10, 2022

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented May 6, 2022 •
edited by Gerrit91
Loading

Expose Register and Report (former finalizeAllocation) via grpc for direct communication from metal-hammer, therefor all metal-hammer related calls are exposed via grpc boot-service, metal-core lost this responsibility of forwarding them.

Also in this PR is the removal of MachineHardwareExtended and MachineNicExtended and move the neighbors field into the MachineNic struct.

requires: metal-stack/metal-go#83

Due to breaking changes in the gRPC API, make sure you update to the latest metal-stack minor release before upgrading to this version. If you don't, rebooting all waiting machines by hand is required.

@majst01 majst01 mentioned this pull request May 18, 2022
Merged
5 tasks
@majst01 majst01 marked this pull request as ready for review May 18, 2022 06:05
@majst01 majst01 requested review from Gerrit91 and mwennrich May 18, 2022 07:27
@majst01
Copy link
Contributor Author

majst01 commented May 23, 2022 •
edited
Loading

machine rebooted from outside after report. This is because the metal-core treats the "power boot hd" event as such that this requires a power reset, see: https://github.com/metal-stack/metal-core/blob/master/internal/event/boot.go#L55

This was addressed with metal-stack/metal-core#64

Gerrit91
Gerrit91 reviewed May 25, 2022
View reviewed changes
pkg/api/v1/boot.proto Outdated Show resolved Hide resolved
pkg/api/v1/boot.proto Outdated Show resolved Hide resolved
pkg/api/v1/boot.proto Outdated Show resolved Hide resolved
cmd/metal-api/internal/grpc/boot-service.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/grpc/boot-service.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/service/v1/machine.go Show resolved Hide resolved
@majst01
Copy link
Contributor Author

majst01 commented May 30, 2022

All review findings addressed so far.

@majst01
Copy link
Contributor Author

majst01 commented Jun 5, 2022

ensure metalctl machine rm still do both, set to PXE and reboot the machine

Gerrit91
Gerrit91 reviewed Jun 10, 2022
View reviewed changes
Makefile Show resolved Hide resolved
Gerrit91
Gerrit91 approved these changes Jun 10, 2022
View reviewed changes
cmd/metal-api/internal/grpc/boot-service.go Outdated Show resolved Hide resolved
cmd/metal-api/internal/grpc/boot-service.go Outdated Show resolved Hide resolved
@majst01 majst01 merged commit 43ece5a into master Jun 10, 2022
@majst01 majst01 deleted the grpc-boot-service branch June 10, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 approved these changes

@mwennrich mwennrich Awaiting requested review from mwennrich

Assignees

@majst01 majst01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majst01 @Gerrit91