Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new linter warnings #165

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix new linter warnings #165

merged 1 commit into from
Aug 26, 2024

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Aug 26, 2024 •
edited
Loading

Without we get a lot of new warnings like:

cmd/client/client.go:73:23: G115: integer overflow conversion uint -> uint32 (gosec)
                                                                Length: uint32(ctx.Uint("length")),
                                                                              ^
prefix.go:236:43: G115: integer overflow conversion int -> uint8 (gosec)
                cp, _, ok = ipset.RemoveFreePrefix(uint8(length))
                                                        ^

@majst01 majst01 requested a review from a team as a code owner August 26, 2024 06:02
@majst01 majst01 requested a review from mwennrich August 26, 2024 06:03
@Gerrit91 Gerrit91 merged commit 65c42b4 into master Aug 26, 2024
3 checks passed
@Gerrit91 Gerrit91 deleted the fix-new-linter-warnings branch August 26, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 approved these changes

@mwennrich mwennrich mwennrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majst01 @mwennrich @Gerrit91