Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud profile version classification dates #9

Draft
wants to merge 58 commits into
base: master
Choose a base branch
from
Draft

Cloud profile version classification dates #9

wants to merge 58 commits into from

Conversation

Gerrit91
Copy link

@Gerrit91 Gerrit91 commented Dec 3, 2024

This is just a draft.

Gerrit91 and others added 20 commits December 2, 2024 16:09
@Gerrit91
Cloud profile classification dates.
d83e57b
@Gerrit91
Update docs.
5b6c011
@crigertg
add example for automatic version upgrades to shoot_versions.md
11fc49a
@crigertg
add core.ClassificationPlanned as supported classification
c613dfa
@Gerrit91
Update.
c6415b2
@Gerrit91
Merge remote-tracking branch 'origin/cloud-profile-version-classifica…
f28504c 
…tion-dates' into cloud-profile-version-classification-dates
@Gerrit91
Documentation update.
b6324c8
@Gerrit91
And neeeext attempt. 😅
0b67b4c
@Gerrit91
Add status.
e6fd608
@vknabel
feat: machine image names
fe76eff
@crigertg
validation(cloudprofile): check if k8s lifecycle of latest version ex…
08da789 
…pires
@crigertg
validation(cloudprofile): don't allow classification/expirationDate a…
30b4ac0 
…nd lifecycle at the same time
@crigertg
validate(cloudprofile): check if there are duplicate lifecycle classi…
9ca3a82 
…fications
@crigertg
validation(cloudprofile): check if lifecycle classifications are in o…
7f6c5b5 
…rder
@Gerrit91
Implement cloud profile status reconciler.
56ce8af
@Gerrit91
One more test.
d0aaf80
@crigertg
validation(cloudprofile): check if lifecycle classification startTime…
54f0a2a 
…s are in order
@crigertg
fix(validation/utils): fix missing return in lifecycleStartTimesInOrder
4c79d05
@crigertg
docs(validation/cloudprofile): add docs for lifecycleStartTimesInOrder
d3b3bf6
@Gerrit91
Remove SVG.
0064412
Gerrit91
Gerrit91 commented Dec 3, 2024
View reviewed changes
pkg/apis/core/validation/cloudprofile.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
crigertg and others added 9 commits December 3, 2024 16:30
Gerrit91 and others added 26 commits December 4, 2024 09:04
@Gerrit91
Provide example of existing impl.
ff501f4
@Gerrit91
GEP-32.
ee87c71
@Gerrit91
Unfinished progress.
20e17fb
@crigertg
add more cloudprofile tests for k8s lifecycle validation
f4df9ed
@crigertg
add helper functions for determining latest versions and classificati…
fd52dba 
…on for cloudprofiles
@crigertg
use helper function for determining expired versions in shoot mainten…
983307e 
…ance
@vknabel
docs(GEP-32): alternatives and variants considered
0d953cb
@Gerrit91
Move tests to helper package.
fa05c92
@Gerrit91
Imports.
078086d
@crigertg
integrate changes for version lifecycle in bastion extension
c919b85
@crigertg
replace version checks with helper functions
30dc635
@Gerrit91
Add validation for cloud profile update.
5913ae4
@crigertg
update resourcereferencemanager with version lifecycle helper functions
f04e8c8
@crigertg
add support for k8s version lifecycles to NamespacedCloudProfiles
02ef5d3
@Gerrit91
Review of GEP. Not sure if vknabel likes it. 😔
04f61a9
@LucaBernstein
Enhance (Namespaced)CloudProfile validation regarding classification …
f9dffb9 
…lifecycle
@Gerrit91
Improve validations, main work was done by @simcod. 🐈
d1c9f12 
# Conflicts:
#	pkg/apis/core/validation/utils.go
@vknabel
feat: machine image versions classification deletion protection
db0cb80
@vknabel
fix: namespacedcloudprofile time travel into the past
04f0a4a
@vknabel
fix: previous startTime should stay nil when empty
c455f9a
@LucaBernstein
Fix NamespacedCloudProfile admission validation tests regarding Kub…
c78d3c0 
…ernetes version classification lifecycles
@vknabel
docs: stage not phase
a31cd19
@LucaBernstein
Refine namings of Lifecycle and LifecycleStage.
4ac5470
@LucaBernstein
Add myself to GEP authors
e0c7e1a
@LucaBernstein
Refactor and rename usages after last field renamings
471dec5
@LucaBernstein
Fix bug with legacy Classification
a430ca1
@vknabel vknabel mentioned this pull request Dec 5, 2024
Merged
@vknabel
Copy link

vknabel commented Dec 6, 2024 •
edited
Loading

Todo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gerrit91 @vknabel @crigertg @LucaBernstein