Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cilium extension to support Cilium 1.15 #403

Merged
merged 38 commits into from
Oct 24, 2024
Merged

Update Cilium extension to support Cilium 1.15 #403

merged 38 commits into from
Oct 24, 2024

Conversation

iljarotar
Copy link
Contributor

@iljarotar iljarotar commented Jun 4, 2024 •
edited by Gerrit91
Loading

Depends on #431

Required Actions

Clusters that use the Cilium CNI do not depend on MetalLB anymore and require new configuration keys in order to run with updated Cilium version `v0.15.4`. These networking configuration settings are `devices: ["lan+", "lo"]`, `bgpControlPlane.enabled: true` and `directRoutingDevice: lo`.

@iljarotar iljarotar requested a review from a team as a code owner June 4, 2024 09:42
@iljarotar iljarotar marked this pull request as draft June 4, 2024 09:42
@iljarotar iljarotar changed the title replace gardener-extension-networking-cilium by fork Add defaults for cilium Jun 4, 2024
robertvolkmann
robertvolkmann reviewed Jun 18, 2024
View reviewed changes
pkg/admission/mutator/defaulter.go Outdated Show resolved Hide resolved
pkg/admission/mutator/config.go Outdated Show resolved Hide resolved
robertvolkmann
robertvolkmann previously requested changes Jun 19, 2024
View reviewed changes
charts/internal/control-plane/values.yaml Outdated Show resolved Hide resolved
pkg/controller/controlplane/valuesprovider.go Outdated Show resolved Hide resolved
@robertvolkmann
Copy link
Contributor

robertvolkmann commented Jun 19, 2024 •
edited
Loading

metallb will still be deployed by the internal Helm chart shoot-control-plane.

@robertvolkmann robertvolkmann force-pushed the update-cilium-extension branch from 0605ad0 to ed55c25 Compare August 1, 2024 05:48
@robertvolkmann
Merge tag 'refs/tags/v0.24.0' into update-cilium-extension
3e5a4d6 
# Conflicts:
#	go.mod
#	go.sum
#	pkg/controller/controlplane/add.go
#	pkg/webhook/controlplane/ensurer.go
@robertvolkmann robertvolkmann force-pushed the update-cilium-extension branch 2 times, most recently from 9917e75 to 3e5a4d6 Compare August 6, 2024 17:09
@simcod simcod force-pushed the update-cilium-extension branch from 8bb1d45 to 3e5a4d6 Compare August 7, 2024 11:17
@robertvolkmann robertvolkmann force-pushed the update-cilium-extension branch from 80b6413 to db73f54 Compare August 7, 2024 12:55
@robertvolkmann
DROP: Allow building container image on merge conflicts
f88b134
@robertvolkmann
Merge tag 'refs/tags/v0.24.2' into update-cilium-extension
d301a52
@robertvolkmann
Use update cilium extension
9fb55eb
@robertvolkmann
It is unnecessary to specify "--devices=lo,..." with Cilium 1.15.8
3e2115d
@robertvolkmann
Merge tag 'v0.24.3' into update-cilium-extension
6c19c9a 
# Conflicts:
#	go.mod
#	go.sum
@robertvolkmann
Merge tag 'v0.24.4' into update-cilium-extension
1f7db92
@robertvolkmann
Revert "It is unnecessary to specify "--devices=lo,..." with Cilium 1…
f06cf65 
….15.8"

This reverts commit 3e2115d.
@robertvolkmann
Merge tag 'v0.24.5' into update-cilium-extension
77f3ada
@robertvolkmann
Merge tag 'v0.24.6' into update-cilium-extension
be287f7
@robertvolkmann
Merge tag 'v0.24.7' into update-cilium-extension
f477828
@robertvolkmann
Merge tag 'v0.24.8' into update-cilium-extension
7c26113 
# Conflicts:
#	go.sum
#	pkg/admission/mutator/config.go
#	pkg/admission/mutator/defaulter_test.go
@robertvolkmann
Fix go.sum
b37b15c
@robertvolkmann
Merge tag 'v0.24.9' into update-cilium-extension
9517153
@robertvolkmann
Revert "DROP: Allow building container image on merge conflicts"
cd62740 
This reverts commit f88b134.
@robertvolkmann
Revert "DROP: Checkout pull request HEAD commit instead of merge commit"
fc0d626 
This reverts commit 0382528.
@robertvolkmann robertvolkmann changed the title Add defaults for cilium Update Cilium extension to 1.15 Oct 16, 2024
@robertvolkmann robertvolkmann changed the title Update Cilium extension to 1.15 Update Cilium extension to support Cilium 1.15 Oct 16, 2024
@robertvolkmann robertvolkmann marked this pull request as ready for review October 16, 2024 11:52
@robertvolkmann robertvolkmann dismissed their stale review October 16, 2024 11:53

Contains own changes

@Gerrit91
Copy link
Contributor

Needs rebase

@Gerrit91 Gerrit91 merged commit bfa57a2 into master Oct 24, 2024
2 checks passed
@Gerrit91 Gerrit91 deleted the update-cilium-extension branch October 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertvolkmann robertvolkmann robertvolkmann approved these changes

@Gerrit91 Gerrit91 Gerrit91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iljarotar @robertvolkmann @Gerrit91 @simcod