Skip to content

Commit

Permalink
Review comments (#1)
Browse files Browse the repository at this point in the history
  • Loading branch information
robertvolkmann authored Sep 3, 2024
1 parent 326e2f0 commit 4415f38
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 14 deletions.
15 changes: 3 additions & 12 deletions pkg/controller/dnsrecord/add.go
Original file line number Diff line number Diff line change
@@ -1,16 +1,7 @@
// Copyright (c) 2021 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file
// SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company and Gardener contributors
// SPDX-FileCopyrightText: 2024 metal-stack Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// SPDX-License-Identifier: Apache-2.0

package dnsrecord

Expand Down
4 changes: 2 additions & 2 deletions pkg/powerdns/secret.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ func readCredentialsSecret(secret *corev1.Secret) (*pdnsclient.Credentials, erro
return nil, err
}

server, _ := getSecretStringValue(secret, Server, true)
server, err := getSecretStringValue(secret, Server, true)
if err != nil {
return nil, err
}

virtualHost, err := getSecretStringValue(secret, VirtualHost, false)
virtualHost, _ := getSecretStringValue(secret, VirtualHost, false)

insecureSkipVerify, err := getSecretBoolValue(secret, InsecureSkipVerify)
if err != nil {
Expand Down

0 comments on commit 4415f38

Please sign in to comment.