Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete PVCs when extension gets deleted or disabled #26

Merged
merged 1 commit into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/gardener-extension-audit/templates/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ rules:
- update
- patch
- delete
- apiGroups:
- ""
resources:
- persistentvolumeclaims
verbs:
- deletecollection
- apiGroups:
- ""
resources:
Expand Down
4 changes: 2 additions & 2 deletions example/controller-registration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ metadata:
name: audit
type: helm
providerConfig:
chart: H4sIAAAAAAAAA+0c/W/btrI/668g1A7bgEr+dgcBfe+lqbcFaxMjyevewzAEtETbamRRo6Q0Wdv//R0/JFOyZNlJmrxuOgSITfE+SN4d746UF5h5JCTMItcJCWOfhhZOPT/pPLk/6AK8GI3Ef4Dyf/G5Nxj2+qP+eMzbe8PhuPsEje5RhlpI4wQzhJ4wSpNt/Zqef6WwqFv/wyVmiX2DV8GdefAFHg+Htevf7/ZK6z8evBg/Qd17GF8j/M3XH0f+O8L4ujvoqmfgKMq/mj27axoeiV3mR4loOkA/k2CFXK4baE4ZSpYECX1Buf4YIV4RB9UplnGV0e/awMB47An4m0Ot/XvUtRf0Xng02f9wXLb/EUBr/w8Bnc6COguuATghKF4iy0WmbXfg74qEHmWdhZ8s05nt0lUnU5b1hyV2LzsZuuXSMGE0CECdGFn4cQKtoFE2kJVOwkbPvnMx/BcM3k1Oz45Ojr9XX8k1XkUB6dRR4XsRmmRq6giKpmF0OmgKUuAFUX6JhHgWkBgVBpZGEVU+SzX64UK4L5cyRtwErdmiAlsj0qn/1fxVrf0nBBYDpi6+eyS4f/w3Ho7Gbfz3ELDD+l8sSRDBpm0n0e1iwQb/3+v3RsX173dfvHjR+v+HgI8fLeSRuR8SZPLAzUTW589GbfDGu8O2IDoZOm6AZySIbYgf7UtyI6mIL+mMsJCAHtk+7XAOBRo1JK5wkCpRPn5EfugGqZcLaCOFuEWQTdyygJyKg2p6KP6C0+Yo/BB0JnSJQLdPSUBwTOxjEK5Sslw0fwXbiJQMIf7En6MljqcMnl8jM17i/mjsANt3nD2w4v3tBC9QjhExP0zmyPwm/tc3cbknIxGN/YSym20kYIykiqBza4IwWG3c5QXxSBTQmxUJExX558oRdyDj0KfrsY3hbwg7+H8IjOb+YoUjSyz+FQRLlFkUVvMD8xPSXCNojv8HJf8/Gg9a//8goNxQwbzfiRU+yRZYOsFCmeDSDz0HHQrFeIsjY0US7OEEO+ASZPpf7barNUghxRBoV/hU0Sy9jfTQToVf5+Q/QSPocoKGvHcmjuAYXxTV1UGfOJGtoy6S07zbYy/ZvcI+9n/bamCD/fdHg3HJ/nuD3qC1/4eA+zLsXEm+qDFLLrkJIwDLssR/fSBCg20ue2Dneh3bCjtTedsNaOpBDIKDaIl7gko+flUKkDORylKAUXKWip4b+CAo9AzBg0A3OTwQttTuiFaQ1HVJxNtBsOT8JiKxmCdG/kh9RjxkNtC3NwkgP87xzSb5qvCVyGKGs9Y9pdIw9xNHR8zl+CPad1YAYz++HCHnN0tZnOzJUeDsx1OibETLFVoF4TNOg+QVdi+hXy5pqdkRhBL6X14ba6DwCYXKpsZV8TrD4YKgZzFxGUmQ83I7uTPRTYjFLbDSjcg+FT5EkbJmkpYleVowD4q9HapkquxMnt3Gmzyr9CbamCEhfI6eiaSPDzwTgvfL0hzRKUsZVddPaDYektAtzeZXFSrssP+vE7hbBgDb9/9et9/vl/f/Ua+N/x8ECtumSsml9b7Ol33nKOCL7P1xRFzOmJErn8v5sx/zisQbf+WDw+6KJ1Hgu1huGJnXUo2HNA0TyTQGWXiIL/fhFU7c5Zvd5BhLAplJKALapIhtPQxpIuKEOGvKqzxN6VXW3V0S9zJOV1rOLayxOm8qLMN3opIDDvJcSWm/gomf4mSJzJ1SePN7MWRZhQIZdLk0l7ZF1K2h4S2EbRArU6JMopAkHygD5d0I8RJqMVADf0Us0PeYMBg4qHsQ0A/E2w3fg1XdDyNKZ6CAluqzNzbzr/iR2k7ojMQ0ZS4o2CYhQLPiJTiv2OJVzPUEWIkbWcPh4D4oSyX9QGbw9TLf1jmDfrffXXNosLMfssXNbD6LSLEPnPOltpqckASh6g4yy4m+XtaEDX3jsSxumkU60zQIphQW9KbgZSRGlD8sWAhdrTB40rzBQp3awvq6j6UM5mWHJG6neozKRjpaPlSgsMLXnIqbMgbzajHCv/gBiV9qsq8PPMVn1fnsJnRjfRic3pLgIFkKk9+ftobcxMdfhJQRi0ZEZlzW2qnWUZcoJxnGQY5Qpp1pp5wzK9+oXm7Zp2qxlQnxM2VdMNVLZo227DTl584lap4f8zNq7cC8MHvq8ToN5cH7e+qHyHxulv2ytr3AlsR8N67iqB5ZMzA1C3seGHb8Utf9GtwKz19iKpe3iqd8Us+yGrOZY+6K1IFCmW9uZOq5PrXbcCs4c3IBXVgB7JmBTgca3/A2WBiVzSDTD+fUrMKeUwbhRgn9R9Go47+P+eGIhk/CK917SK/36uDwl8nx64uzyeHp5Pzi+ODt5Gx6cDjJOyIk0pMfGV05WiNCc58E3imZF1tVO998nTyosXPzaOI/PZ38ePSfMvPaHG+D3JvJwevJ6cXkzeTw/Ojk+OHGs2dolsl79Pbgp8k7EPbk9OLk3eT019Oj8w1ZHdQRt0W0unOnshC9Tfe4c4k31z/zRNK7aJzzjZJbVGGX2sUtAT9GE+rSwEHnh9NyrSsPBHScvFFE0KUqxBpjXXjodUsJcj5rNEhX5C0P1iuGLJ2uJuqKd5Qr3LxL3nXF684sqoTZWHWtHyPYOwkDCCASlpL6lefr47vkwHU54ePmUOcpwvO5H/rJjZO3cPXxDiDmPah4hPKK1esUAvHFGWzOXhrApyOxm6rmyTVxU71y+VTNiwjdzgrpVPZQTAhPrSbXEXf4ejq07mGhS3JTe/qen89v4CEkQwPgio7CisfC+ioYcpY7nPUX0RIaUXDUN79wWc3iHYAljROxEApHKvBGiFrSQDcrrOsua+e6egbKtb6lHuAN+131aC/13k2595e3yVi2yP7V1Mz+SrBD/Q8cCQSkLBV3wGeptyB7FgKbzv9Hwxel+t9gOGzv/z8IKKexSNB3vCJTVT37HvXKVwAikex2rnoziK+yguGUeq9zPXkl9OT/o3IIGeu/Q3yF/YBnVYJ8nM4aB3zniuHX4NR2sH8GIfydXgRqsP/BuFu+/8PvBLT2/xBQPrwTi43TZEmZ/6e8AH/5g4h41rcDApgzwk5pQPax730sl6UBj6XUP4sf7v/EaBqJ+MpC2pl+sSxpFHIS3tWVwsbwBaKRmWrlrkkEsn4sP3zgtr3JCHsrX8SwhTcC5IRs8lqliXitQKVbrn53YDcB+Kc0ggklUnhIGdTHqFrAPWZi3bX0tQMWkKS7CxiVRd2Qqq5qXDFlOIR40ctbdxZCmxptwtaieeC6q0QzzU0hZGlCTksebz+OKPkmeEuFraIJ4XiYlOhtk3mDqEsp8/xwu/KL3XonLk1j2I9d1i7ihJKmq3MJ6OvxHS6QlzCKMmqC8Ul+iryQX+hwQYYYNIOsIA1EM4IwfytIZbT/vJMhAgNFv/R1H0PcEABCdJcnXDe1UwahSEQh5okh0NlVv+60O7yCBnCHX2yTABaq+pfNxRYJjfxyl7Z9NcgDUeJ70BmxBWVXWvTazP0EtY+6/+8Q/6l61O1DwKb3f0ajXvn+R7c7bOO/h4Cai1tixe8/e9u4I7HLUfOc0ZUFvQLP4gfjoiqOvv3to5kVrE3HPD+cms9N/sx0dit8f/792/0k4MfdWe0dVAY8Zmypc+1HESqfcStLU5UEWp4KfEt1y8KBCMgoiZqfPz/fQCzx4+4WEMSJv7mXpBH1LOHEc0nXp68whT6/uVOITm+T5Cfixqpy7kfTQva+2/We/LzFEh8dNBwOxBiLByOiMizWf69zlsc29BrY3f9juefdYhtoqv/1h2X/3x+MWv//ILDN/2dRzqMW8R57gv7iUGv/8iTtXn4AqOn9n95g4/3/9v2/BwJ5SU4ki9mlOActli7LggXYtBPxIx/1N9cSvHCQ2Cv4t0i7KXc0P6bJFAIDfovY0GvsDuoZ6/wUffxsGNplKPWuj35VzEEjaNTukskAsq4XS2YEJ7IPPCUfjkKIC0Cpz/h9NQ86DvjZY+3tMQfNcRATw9i8i+Wg337Pmn+VO75sM56iqkNX/qYSP1KWF0Ac8Tk7fo1wGstrYOLmhiGPnuW0nOorsv4RlnU8p3+cBXTWWWEe/HRmqR9A1MVJd15T95KwuQ/Jbnbyr1GVy7ygdBGQi/VFS4lr4ZU3Hio0scbmgP8ilGzIf8apZ/d69vXXParexqjMf7zkI+vLB7ZtG0YhunMMeVEju23DY0XDzR9Vv/tV9eYXjoRR8E4dfgEs0+r1W1iVPcT7UZAmiy/q5SXwo4ZR8YrQRpt6eUcK9TRfttWNuqVlZLcg1vfb5fRAD3FxA/6L/cHIfynCMfTJM9ttu4UWWmihhRZaaKGFFlpooYUWWmihhRZaaKGFFlpooYUWWmihhRZaaKGFFlpooYUWviD8Dz6hSZYAeAAA
chart: H4sIAAAAAAAAA+0ca2/bRjKf+SsWTA5tgZB6ywWB3J3jqK3RxBZsX3qHojBW5EpiTXJZPhz7kvz3m32QWr5EyXbsS8uBAUvLncfuzszOzC61wpFDAhIZ5CYhQezSwMCp4ya9Zw8HfYCDyYT/Byj/558Ho/FgOBlOp6x9MB5P+8/Q5AFlaIQ0TnCE0LOI0mRbv7bnXymsmtb/aI2jxLzFvndvHmyBp+Nx4/oP+4PS+k9HB9NnqP8A42uFv/j649B9TyK27ha6Hmg4DPOv+sDs65pDYjtyw4Q3HaKfiOcjm+kGWtIIJWuCuL6gXH+0APvEQk2KpV1n9PsmMNCeegL+4tBo/w61zRV9EB5t9j+elu1/AtDZ/2NAr7ei1oppAE4IitfIsJFumj34uyaBQ6Peyk3W6cK0qd/LlGXzYY3tq16Gbtg0SCLqeaBOEVm5cQKtoFEmkBVOwkQvvrUx/OcM3s/Ozo9PT76TX8kN9kOP9JqosL0IzTI1tThFXdN6PTQHKfCKSL9EArzwSIwKA0vDkEqfJRvdYMXdl02jiNgJ2rBFBbZaqFL/s/mrRvtPCCwGTF18/0hw//hvOp5Mu/jvMWCH9b9cEy+ETdtMwrvFgi3+fzAcTIrrP+wfHBx0/v8x4ONHAzlk6QYE6Sxw05Hx+bPWGLyx7rAt8E6aiuvhBfFiE+JH84rcCir8S7ogUUBAj0yX9hiHAo0GEtfYS6UoHz8iN7C91MkFNJFE3CJIFbcsIKNioYYekj/nVB2FG4DOBDbh6OYZ8QiOiXkCwtVKlovm+rCNCMkQYk/cJVrjeB7B8xukx2s8nEwtYPuesQdWrL+Z4BXKMcLIDZIl0v8W//NvcblnREIauwmNbreRgDGSOoLWnQnCYJVxlxfEIaFHb30SJDLyz5Uj7kHGoU7XUxvDXxB28P8QGC3dlY9Dgy/+NQRLNDIorOaHyE1Ie42gPf4flfz/ZDrq/P+jgHRDBfN+z1f4NFtg4QQLZYIrN3AsdMQV4x0ONZ8k2MEJtsAliPS/3m3Xa5BEiiHQrvGpvFl4G+GhrRq/zsh/gkbQ5QSNWe9MHM4xviyqq4U+MSJbR10kp3i3p16yB4V97P+u1cAW+x9ORtOS/Q9Gg1Fn/48BD2XYuZJ8UWMWXHITRgCGYfD/6kC4BptMds/M9To2JXam8qbt0dSBGAR74RoPOJV8/LIUIGYiFaUAreQsJT3bc0FQ6BmAB4FuYnggbKnd4q0gqW2TkLWDYMnFbUhiPk8R+SN1I+IgvYW+WSWA3DjH19vkq8OXIvMZzlr3lErB3E8cFTGX449w31kBjP34MoSc3yKN4mRPjhxnP54CpRIt12gVhM849ZLX2L6CfrmkpWaLE0rof1htrIXCJxRIm5rWxesRDlYEvYiJHZEEWa+2kzvn3bhYzAJr3YjoU+NDJCljIWgZgqcB8yDZm4FMpsrO5MVdvMmLWm+ijBkSwpfoBU/62MAzIVi/LM3hnbKUUXb9hBbTMQns0mx+VaHCDvv/JoG7YwCwff8f9IfDYXn/nwy6+P9RoLBtypRcWO+bfNl3jgK+yN4fh8RmjCNy7TI5f3JjVpF46/ouOOw+fxJ6ro3FhpF5Ldl4RNMgEUxjkIWF+GIf9nFir9/uJsdUEMhMQhJQJoVv60FAEx4nxFlTXuVpS6+y7vaa2Fdx6is5N7fG+rypsAzf8koOOMgLKaX5GiZ+jpM10ndK4fXv+JBFFQpkUOVSXNoWUbeGhncQtkWsTIkyiQKSfKARKG8lxEuoEYEauD4xQN9jEsHAQd09j34gzm74DqzqfhhhugAFNGSfvbEj95odqe2EHpGYppENClYlBGhGvAbnFRusirmZACOxQ2M8Hj0EZaGkH8gCvl7l2zpjMOwP+xsOLXb2fba4mc1nESl2gXO+1EabExLAVd1CejnRV8uasKFXHovipl6kM089b05hQW8LXkZghPnDgoVQ38fgSfMGA/UaC+ubPoY0mFc9kti9+jFKG+kp+VCBgo9vGBU7jSKYVyMi7IvrkfiVIvvmwJN/lp3PbwM7VofB6K0J9pI1N/n9aSvIbXzcVUAjYtCQiIzL2DjVJuoC5TTDOMwRyrQz7RRzZuQb1ast+1QjtjQhdqasCiZ7iazRFJ3m7Ny5RM1xY3ZGrRyYF2ZPPt6koSx4/526AdJf6mW/rGwvsCVFrh3XcZSPjAWYmoEdBww7fqXqfgNujecvMRXLW8dTPGlmWY/ZzjF3RfJAocw3NzL5XJ3abbg1nBk5j64MD/ZMT6UDjW9ZGyyMzGaQ7gZLqtdhL2kE4UYJ/QfeqOL/HrPDEQWfBNeq9xBe7/Xh0c+zkzeX57Ojs9nF5cnhu9n5/PBolndEiKcnP0TUt5RGhJYu8Zwzsiy2yna2+Vp5UGPm5tHGf342++H432XmjTlehdzb2eGb2dnl7O3s6OL49OTxxrNnaJbJe/zu8MfZexD29Ozy9P3s7Jez44uKrBbq8dsiSt25V1uI3qZ7zLnE1fXPPJHwLgrnfKNkFlXYpXZxS8Avogm1qWehi6N5udaVBwIqTt7II+hSFWKDsSk8DPqlBDmfNeqlPnnHgvWaIQunq4jqs45ihdt3yfuueNOZRZ0wlVVX+kUEO6eBBwFEEqWkeeXZ+rg2ObRtRvikPdR5jvBy6QZucmvlLUx9nEOIeQ9rHqG8YvUmhUB8dQ6bs5N68OmY76ayeXZD7FStXD6X88JDt/NCOpU95BPCUqvZTcgcvpoObXoY6IrcNp6+5+fzFTyERGgAXNFxUPOYW18NQ8Zyh7P+IlpCQwqO+vZnJqtevAOwpnHCF0LiCAWuhKglDbSzwrrqsnauq2cgXes76gDeeNiXj/ZS792Ue39524xli+xfTc3szwQ71P/AkUBAGqX8DvgidVZkz0Jg2/n/ZHxQqv+NxuPu/v+jgHQaqwR9yyoyddWz79CgfAUg5Mlu73qwgPgqKxjOqfMm15PXXE/+PyqHkLH+K8DX2PVYVsXJx+midcD3rhh+DU5tB/uPIIS/14tALfY/OhhV7n8Op4PO/h8Dyod3fLFxmqxp5P5XXIC/+p5HPJvbAR7MGYnOqEf2se99LDdKPRZLyX8GO9z/MaJpyOMrAyln+sWypFbISVhXWwgbwxeIRhaylbkmHsi6sfjwgdl2lRF2fJfHsIU3AsSEVHn5acJfK5Dplq3eHdhNAPYpDWFCiRAeUgb5MawXcI+Z2HQtfe2BBSTp7gKGZVErUjVVjWumDAcQLzp5685CKFOjTNhGNAdcd51oul4Vgl1uBw7shiqP4m0Pu35JFEHPZtU4fpK/G2VR9BATnkfyTzPIfHu9oynU0YRAP0hK9LbJXCFqUxo5brDdrHgcsBOXtjHsxy5r5xFIyYbkiQf0ddjemSlFQUZFMDbJz5ETsKsiNsgQg2YQHxJMtCAIs/eNZK78j3uZODCQ9Etf9zHxigAQ/NsslbttnDIIckIK0VQMIdSu+nWvfec1NICj/WLbD7CQdcVsLrZIqOXXxpSNsUUeiD9/B53hm1t2WUat+jxMuLzD/r9D/CfrUXcPAdve/5lMBuX7H/3+uIv/HgMaLm7xFX/47K1yR2KXo+ZlRH0DenmOwQ7GeVUcffPrRz0rWOuWfnE011/q7Jlu7Vb4/vzbN/tJwI67s9o7qAz4tdiQ59pPIlQ+40aWpkoJlDwV+JbqloUDEZBRENU/f35ZQSzxY04REPiJv76XpCF1DO5qc0k3p68whS67uVOITu+S5Cf8xqp0wcfzQva+2/We/LzF4B8tNB6P+BiLByO8MszXf69zlqc29AbY3f9jsTPdYRtoq/8Nx2X/PxxNOv//KLDN/2exyJMW8Z56gv7k0Gj/4iTtQX4AqO39n8Go8v5/9/7fI4G4JMdTuuxSnIVWazvKggXYtBP+Ix/NN9cSvLIQ3yvYt1C5KXe8PKHJHAIDdotYU2vsFhpomywSffysacplKPmuj3pVzEITaFTukokAsqlXlCwITkQfeEo+HAcQF4BSn7P7ag50HLGzx8bbYxZaYi8mmla9i2WhX3/Lmn8RO75ogxS/7tCVvanEjpTFBRCLf86OX0OcxuIaGL+5oYmjZzEtZ+qKbH6EZRPPqR8XHl30fMyCn94idT2Iuhjp3htqX5Fo6UJKmp38K1TFMq8oXXnkcnPRUuAa2HemY4nG11gfsV+EEg35zzgNzMHAvPm6RzWojEr/+ys2sqF4YJqmphWiO0sTFzWy2zYsVtTs/FH9u191b37hkBsF69RjF8Ayrd68hVXbg78fBWky/yJfXgI/qmk1rwhV2uTLO0Ko5/my+bfylpaW3YLY3G8X0wM9+MUN+M/3By3/pQhLUydP77btDjrooIMOOuiggw466KCDDjrooIMOOuiggw466KCDDjrooIMOOuiggw466KCDDjr4gvA/zURGxQB4AAA=
values:
image:
tag: v0.1.0
tag: v0.1.6
---
apiVersion: core.gardener.cloud/v1beta1
kind: ControllerRegistration
Expand Down
7 changes: 7 additions & 0 deletions pkg/controller/audit/actuator.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,13 @@ func (a *actuator) deleteResources(ctx context.Context, log logr.Logger, namespa
return err
}

// TODO: since k8s v1.27 there is a new feature to delete the pvc automatically when the statefulSet is deleted
// https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#persistentvolumeclaim-retention
err := a.client.DeleteAllOf(ctx, &corev1.PersistentVolumeClaim{}, client.MatchingLabels{"app": "audit-webhook-backend"}, client.InNamespace(namespace))
if err != nil {
return err
}

return nil
}

Expand Down
Loading