Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional information/references #209

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

scoopex
Copy link
Contributor

@scoopex scoopex commented Aug 23, 2024

Enhance and rework networking document

  • reworked and enhanced the documentation to make
    it to improve understanding for newbies
  • added a reference to the "Cloud Native Data Center Networking" book
  • added so references to RFC documents
  • added a description which provides to details behind the sharing of ASNs
  • remove a outdated reference from 2020 to switch of the deactivation of ipv6
    by setting net.ipv6.conf.swp1.disable_ipv6=0.
    Without checking that, i guessed that this be fixed in the year 2024 :-)

@scoopex scoopex requested a review from a team as a code owner August 23, 2024 11:41
@scoopex scoopex requested a review from Gerrit91 August 23, 2024 11:41
@metal-robot
Copy link
Contributor

metal-robot bot commented Aug 23, 2024

Thanks for contributing a pull request to the metal-stack docs!

A rendered preview of your changes will be available at: https://docs.metal-stack.io/previews/PR209/

@scoopex scoopex marked this pull request as draft August 23, 2024 11:41
@majst01
Copy link
Contributor

majst01 commented Aug 30, 2024

Hi @scoopex

nice, have you already started with the implementation for your project ?

@scoopex
Copy link
Contributor Author

scoopex commented Sep 3, 2024

Hi @scoopex

nice, have you already started with the implementation for your project ?

Yes, there are some Openstack Changes and a Netbox integration in progress.

I initially enriched this branch with a few references just for internal discussion with a colleague, but then also made a few extensions based on assumptions (e.g. the diagram).

I think this documentation is very good and informative and it would be great if we could optimize it further.

Would you like to take a look at it and see if it makes sense or do you have a short explanation for the open questions that I have marked with “Q:”. Since my specialization is not in network engineering, I was not able to provide compact or reliable descriptions that are both absolutely correct and easy to understand for newcomers.

@majst01
Copy link
Contributor

majst01 commented Sep 3, 2024

Maybe we can have a short discussion together with @robertvolkmann.

We also started with netbox but it was far to slow for our expectations and we created https://github.com/metal-stack/go-ipam therefor

@scoopex
Copy link
Contributor Author

scoopex commented Sep 3, 2024

Maybe we can have a short discussion together with @robertvolkmann.

We also started with netbox but it was far to slow for our expectations and we created https://github.com/metal-stack/go-ipam therefor

For Openstack and Netbox @matofeder is the best person for a discussion.
For the documentation i can do this.

Which topic should we start with or which topics are interesting for a conferenced exchange?

@Gerrit91 Gerrit91 removed their request for review September 11, 2024 13:34
@scoopex
Copy link
Contributor Author

scoopex commented Sep 24, 2024

Hello @majst01 and @robertvolkmann: Today i asked myself - how do you configure K8s MetalLB in bare metal installations with that setup? For Openstack, we just add the Service IPs to the dummy interfaces and the nodes FRR does its job to announce the availability of that address over the BGP peering with the next leaf switches.

For K8s the standard MetalLB mechanism using L2 Broadcasts for leader election cannot work.
Yes, there is the BGP mode for MetalLB, but that seems a bit ineffective and overcomplicated because this spawns an additional FRR instance in my understanding. Is there a more efficient solution? Can you provide a sourcecode/configuration reference?

I also discovered a issue which seems to address this.
Is "backend: None" an option to https://github.com/techno-tim/k3s-ansible/blob/master/roles/k3s_server_post/templates/calico.crs.j2#L10C3-L10C65 ?

@mwindower
Copy link
Contributor

Hi @scoopex,
we have just one FRR instance running on the bare metal nodes.
This advertises static adresses of the machine s. https://github.com/metal-stack/metal-networker/blob/b22c35f65a2b4f7baf665541c2dceb4484bc2f25/pkg/netconf/tpl/frr.machine.tpl
Also it allows peering connections (bgp listen range). In the Kubernetes setting metal-lb is used in L3 mode so that it peers with the underlying FRR instance on the metal node.

@scoopex scoopex changed the title [DRAFT] Add so additional information/references Add so additional information/references Oct 25, 2024
@scoopex scoopex marked this pull request as ready for review October 25, 2024 09:49
@scoopex
Copy link
Contributor Author

scoopex commented Oct 25, 2024

@robertvolkmann Thanks for the reference to the book. As discussed i eliminated the open questions and tried to put my understanding in the document.

- reworked and enhanced the documentation to make
  it to improve understanding for newbies
- added a reference to the "Cloud Native Data Center Networking" book
- added so references to RFC documents
- added a description which provides to details behind the sharing of ASNs
- added a illustration diagram for the server and switch types
- remove a outdated reference from 2020 to switch of the deactivation of ipv6
  by setting net.ipv6.conf.swp1.disable_ipv6=0.
  Without checking that, i guessed that this be fixed in the year 2024 :-)

Signed-off-by: Marc Schöchlin <[email protected]>
@scoopex
Copy link
Contributor Author

scoopex commented Nov 29, 2024

@robertvolkmann Are there open topics which prevent a merge?

@scoopex scoopex changed the title Add so additional information/references Add additional information/references Dec 1, 2024
@robertvolkmann
Copy link
Contributor

@Gerrit91 @majst01 could you approve and merge?

@majst01 majst01 merged commit dabe6ac into metal-stack:master Dec 9, 2024
2 checks passed
majst01 added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants