-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Meilisearch Support #54
Conversation
…e-sidecar into meilisearch-support
Integration fails now because initially test timeout was set to 10m, raised it to 20m to make it pass, but a better approach would be to make a matrix job which iterates over database and restore/upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this effort, I know it's cumbersome. Looking forward to get this running!
During @majst01 vacation, I took over this PR. 😅 I applied the following changes now:
Still need to think about all the error handling one more time. |
return fmt.Errorf("could not clean backup directory: %w", err) | ||
} | ||
|
||
if err := os.MkdirAll(constants.BackupDir, 0777); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this too broad? Would 755 or something similar be enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably yes, but there are many other places where same permissions are used. Maybe we should create a separate PR and address this.
implements #47
TODO: