New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix destroy event not firing #1304

Open

gpoole wants to merge 2 commits into metafizzy:master from gpoole:fix-destroy-event-not-firing

gpoole commented May 9, 2024 •

edited

Loading

The destroy event was effectively not firing due to allOff being called and removing any destroy listeners before the event was emitted.

This change fixes that issue and introduces an assertion for the event being fired.

gpoole added 2 commits

May 9, 2024 15:54


          Add failing test for destroy event firing

5f01942


          Fix destroy event not firing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet