Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API package godocs that summarize and favor the v1 API over v0 #292

Merged
merged 2 commits into from
Apr 28, 2017

Conversation

jdef
Copy link
Contributor

@jdef jdef commented Apr 24, 2017

No description provided.

@coveralls
Copy link

coveralls commented Apr 24, 2017

Coverage Status

Coverage decreased (-0.04%) to 36.425% when pulling d662a59 on jdef_initial_v1_package_godocs into d09f663 on master.

@jdef jdef added PTAL and removed WIP labels Apr 24, 2017
@pires
Copy link
Contributor

pires commented Apr 24, 2017

Just my two cents, but I don't like api/v1/lib subpackage. I'd move examples as part of the api/v1 package where possible. In case an example doesn't make sense or doesn't work following that method, move it to /examples/v1.

@jdef
Copy link
Contributor Author

jdef commented Apr 25, 2017

The examples are pretty complex. examples/{v0,v1} is something I could get behind. Though I would sort of feel bad reorganizing the repo twice in such a short time period.

@jdef
Copy link
Contributor Author

jdef commented Apr 25, 2017

proposal for (yet again) restructuring the repo: #294

@pires
Copy link
Contributor

pires commented Apr 25, 2017

That's what we, software engineers, do all the time: move things around and call it fancy names like refactor, redesign, restructure. Do it 👍

@coveralls
Copy link

coveralls commented Apr 28, 2017

Coverage Status

Coverage increased (+0.02%) to 36.49% when pulling b31688f on jdef_initial_v1_package_godocs into accb133 on master.

@jdef
Copy link
Contributor Author

jdef commented Apr 28, 2017

committing this change to offer guidance until restructuring takes place

@jdef jdef merged commit ccb4d6e into master Apr 28, 2017
@jdef jdef removed the PTAL label Apr 28, 2017
@jdef jdef deleted the jdef_initial_v1_package_godocs branch April 28, 2017 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants