[Feature request]: Nodes quick options #307
Open
+9,571
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The image you linked 404s
|
|
@Hunter275 it is just gif of a feature. Now it should work. |
Hunter275
added
enhancement
|
This should be good to go if there aren't any more wishes. EDIT: |
|
@Hunter275 now it should be ready |
|
This is latest. |
|
Screenshots of "Node Details" |
danditomaso
requested changes
Jan 30, 2025
| timestamp: number; | ||
| } | ||
|
|
||
| const getTimeAgo = (timestamp: number): string => { |
There was a problem hiding this comment.
I'd prefer we avoid using setIntervals to manually calculate time. There is a Browser API Intl which offers a built in api to calculate elapsed time, here is an article with some code you could re-use:
https://dev.to/madsstoumann/showing-time-ago-in-a-social-feed-using-intlrelativetimeformat-5ceo
|
I think there is also some issues with the time ago that is being calculated (any nodes that show "days ago")
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar features are in mobile apps.
When you are on the "Nodes" page, you can click on the node name and a popup pops out.
For now, the popup contains Traceroute and Request position buttons.