-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update CI workflows #127
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
go-version: 1.19 | ||
check-latest: true | ||
cache: true | ||
- name: Create cluster using KinD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acald-creator Why does running the unit tests require a kind cluster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Revolyssup From the original file at https://github.com/meshery/meshery-app-mesh/blob/master/.github/workflows/ci.yml this is already there. The only difference I did was removed the other checks such as errcheck, vet and gosec because golangci-lint already does this.
This is the same test done through all the adapters repo. Does this section need to be revised or removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this is reflected in the Makefile as well
## Run Golang tests
test: dep-check
export CURRENTCONTEXT="$(kubectl config current-context)"
echo "current-context:" ${CURRENTCONTEXT}
export KUBECONFIG="${HOME}/.kube/config"
echo "environment-kubeconfig:" ${KUBECONFIG}
GOPROXY=direct GOSUMDB=off GO111MODULE=on go test -v ./...
Signed-off-by: Antonette Caldwell <[email protected]>
bump |
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell [email protected]
Description
This PR fixes some of the repetitive workflows.
We should start working toward updating golangci-lint to the latest, and also note that some of the steps in the workflows are already implemented within
golangci-lint
such aserrcheck
andgosec
.This current file
.golangci.yml
is copied from the other repos, so this will need to be updated accordingly.Notes for Reviewers
Signed commits