Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add balance to the process #187

Merged
merged 8 commits into from
Mar 17, 2020
Merged

Add balance to the process #187

merged 8 commits into from
Mar 17, 2020

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented Mar 12, 2020

dependency: #186, mesg-foundation/engine#1723

  • add transfer message to the account api
  • add cli command account:transfer
  • create a transfer to the process when created

@antho1404 antho1404 self-assigned this Mar 12, 2020
@antho1404 antho1404 requested a review from NicolasMahe March 12, 2020 14:15
@antho1404 antho1404 added enhancement New feature or request @mesg/api Related to @mesg/api @mesg/cli Related to CLI labels Mar 12, 2020
@antho1404 antho1404 added this to the next milestone Mar 12, 2020
packages/cli/CHANGELOG.md Outdated Show resolved Hide resolved
packages/cli/src/commands/account/transfer.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/account/transfer.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/account/transfer.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/process/create.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/process/create.ts Outdated Show resolved Hide resolved
@antho1404 antho1404 force-pushed the feature/process-balance branch from ea02324 to 78cea09 Compare March 16, 2020 15:50
@@ -36,6 +37,7 @@ export default class ProcessCreate extends Command {
if (hashes.length != 1) throw new Error('error while getting the hash of the process created')
const hash = hashes[0]
this.spinner.stop(hash)
return this.lcd.process.get(hash)
}
const process = await this.lcd.process.get(hash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change doesn't need to be but not blocking

@NicolasMahe NicolasMahe merged commit e2d39e9 into master Mar 17, 2020
@NicolasMahe NicolasMahe deleted the feature/process-balance branch March 17, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request @mesg/api Related to @mesg/api @mesg/cli Related to CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants