Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client side generation #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added client side generation #4

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 18, 2018

added SwaggerUi
added Nswag

SwaggerUi:
Graphical interface for api at port localhost:5001/swagger
generates json to accomplish this

Nswag:
uses this json to create the api calls with there required parameters
also supplies the necessary object types.

automated this in a AfterBuild process resulting in a generated.ts
generates.services.ts is used to extend this file with the header logic and refresh token.
all the settings for this file come from debug.nswag, you can open this file with NswagStudio to see all the options.

Bart Gevaert added 2 commits February 18, 2018 14:53
Nswag requires SwaggerUi in order to generate the typings and routes to the api automatically.
Added a after build command to automate this process.
added SwaggerUi
@merijndejonge
Copy link
Owner

Thanks for your contribution.
I'm little bit confused however about what to do with it. My main goal of OidcTemplate is to maintain a set of projects that add OIDC support but stay as close as possible to the original VS project templates. This is to 1) make as clear as possible what the minimal steps are to add OIDC authentication to your projects in the right way; 2) make integration of this functionality in your own projects straight forward.

It looks that your contribution is adding additional functionality and that it is therefore not in line with this project goal. How do you look at this?

@ghost
Copy link
Author

ghost commented Feb 19, 2018

You're completely right! I've realized i'm kinda out of scope with this.
I didn't know where to start really when i found this project.
So i started contributing where i could instead of contributing in the scope of this project.

Do you happen to have Todos?
I'd like to help out.

@merijndejonge
Copy link
Owner

Thanks for your enthusiasm about the project!
I do not really have ToDo's at the moment, apart from validating the code.
Since we both agree that the pull-request is a bit off-topic, will you close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant