Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add introspection support to query metadata from sqlq #26

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

riyaz-ali
Copy link
Contributor

@riyaz-ali riyaz-ali commented Jan 11, 2023

This PR adds support for inspecting and querying meta-information from sqlq. Closes #22

@riyaz-ali riyaz-ali added the enhancement New feature or request label Jan 11, 2023
@riyaz-ali riyaz-ali requested a review from a team as a code owner January 11, 2023 13:39
@riyaz-ali riyaz-ali self-assigned this Jan 11, 2023
@ramiroJCB
Copy link
Contributor

is this completed ? otherwise lets change this to draft :)

Copy link
Contributor

@amenowanna amenowanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riyaz-ali Can you please document and expand on ENUM and Complex types like the ones you are introducing here in Notion. My concern on these types is that they will limit our compatibility. Postgraphile seems to support them. The docs for SQLC do not document their support (not saying they don't). We already have issues with porting our current schemas to other database providers that don't support things like UDF's and UUID and I would prefer not to add to the mix if we can. If we convert this to an ENUM table the portability increases IMO.

https://www.notion.so/mergestat/PostgreSQL-Schemas-5954fae036374c85a904d361149fc309

@riyaz-ali
Copy link
Contributor Author

My reason behind having a custom type (and not simply using the underlying table definition) is that I don't want to expose the "internals" of the sqlq schema to the user. The only way I found with custom functions is to add a custom type and return that.

@patrickdevivo
Copy link
Contributor

Just want to check in here on what the go-forward should be for this PR. Are we okay with ENUMs once we've documented them a bit internally as to why/where we'd choose to use them?

@amenowanna amenowanna marked this pull request as draft January 16, 2023 05:09
@amenowanna
Copy link
Contributor

We are going to convert this to a draft PR as not all of the views we need have been identified and added. We will create a list of the views we need and start working to add them to this PR as we continue to work on them. This will not be a blocking draft as we will continue to work on the other issues. @riyaz-ali will also still need to document ENUMS in notion.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add introspection support to query metadata from sqlq
5 participants