Update method name

mercyoseni · Jul 29, 2019 · 4783aab · 4783aab
1 parent a4e2658
commit 4783aab
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/helpers/mushrooms_helper.rb b/app/helpers/mushrooms_helper.rb
@@ -5,7 +5,7 @@ def mushroom_attributes_values(key)
     MUSHROOM_ATTRIBUTES[key].values
   end
 
-  def filter_selected?(key, value)
+  def selected_filter(key, value)
     if params[:filter].blank?
       ''
     elsif params[:filter][key]&.include?(value)

diff --git a/app/views/mushrooms/_filter_option.html.erb b/app/views/mushrooms/_filter_option.html.erb
@@ -2,7 +2,7 @@
   <select name='filter[<%= field.to_s %>][]' id=<%= field.to_s %> multiple>
     <option value='' class='placeholder' disabled><%= placeholder %></option>
     <% mushroom_attributes_values(field).each do |value| %>
-      <option <%= filter_selected?(field, value) %> value=<%= value %>>
+      <option <%= selected_filter(field, value) %> value=<%= value %>>
         <%= value %>
       </option>
     <% end %>

diff --git a/spec/helpers/mushrooms_helper_spec.rb b/spec/helpers/mushrooms_helper_spec.rb
@@ -22,18 +22,18 @@
     end
   end
 
-  describe '#filter_selected?' do
+  describe '#selected_filter' do
     context 'when filter params is present' do
       it "returns 'selected'" do
         params[:filter] = { odor: 'fishy' }
 
-        expect(filter_selected?(:odor, 'fishy')).to eq('selected')
+        expect(selected_filter(:odor, 'fishy')).to eq('selected')
       end
     end
 
     context 'when filter params is NOT present' do
       it 'returns an empty string' do
-        expect(filter_selected?(:odor, 'fishy')).to eq('')
+        expect(selected_filter(:odor, 'fishy')).to eq('')
       end
     end
   end