Introduce PredefinedEditorType #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mschindlerMM Do you think we should make this configurable? |
I think it makes sense to make it configurable. And we should probably also make the api more similar to ag-grid. We will probably need the rows and cols attributes too anyway. |
hingew
force-pushed
the
feature/increase-max-length-for-large-text-editor
branch
from
66759c9
to
12e83ab
Compare
hingew
changed the title
mschindlerMM
requested changes
Nov 7, 2024
hingew
force-pushed
the
feature/increase-max-length-for-large-text-editor
branch
from
12e83ab
to
4268f91
Compare
hingew
force-pushed
the
feature/increase-max-length-for-large-text-editor
branch
from
4268f91
to
c92beeb
Compare
mschindlerMM
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce the PredefinedEditorType to enable more options on predefined editors like
agLargeTextCellEditor