New range parameters #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathieu-Be
reviewed
Oct 14, 2024
src/oracle/LBHooksOracle.sol
Outdated
| /** | ||
| * @title LB Hooks Oracle | ||
| * @dev Abstract contract for the LB Hooks Oracle Rewarder | ||
| * This contract allows to distribute rewardsto LPs of the [oracleId + deltaBinA, oracleId + deltaBinB[ bins |
src/oracle/OracleIdChainlink.sol
Outdated
Comment on lines
68
to
70
| if (answer <= 0 || uint256(answer) > type(uint128).max) revert OracleIdChainlink__InvalidPrice(); | ||
| if (block.timestamp > updatedAt + _heartbeat) revert OracleIdChainlink__StalePrice(); | ||
|
|
There was a problem hiding this comment.
If this reverts it will prevent anyone from doing anything with the pair, isn't it a bit too much ? Of course we can disable the oracle but that would take a few hours, it might be more acceptable to just skip updating the id ? (meaning we store the previous answer of this function in the contract storage and use it if the oracle is failing for some reasons)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the contracts to allow different range settings: