Effectiveness metrics #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanposhiho
reviewed
Sep 8, 2024
There was a problem hiding this comment.
I'm OK with the change, but, I'm not sure if it's the best solution for Mercari.
If you haven't yet, I'd suggest looking for ideas other than metrics to calculate this because adding new custom metrics to datadog is expensive. (especially given new six metrics you added have many labels... 💸 💸 💸 )
|
@sanposhiho We will proceed with this for now and look into reducing the metrics in the future as we create the dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds new metrics to measure the effectiveness of tortoise in cost savings
Which issue(s) this PR fixes:
#411
Fixes #
Add net change metrics to measure decreases in usage
Add counters for every time tortoise makes changes to resources as a measure of engineering toil
Special notes for your reviewer: