ignore high replica number for the first 30 min #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er is smaller than minreplicas
sanposhiho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To prevent the deployment from creating too many but too small replicas, Tortoise has the feature that when the replica number goes higher than 30 (this threshold is configurable via PreferredMaxReplicas), it tries to make Pods vertically bigger.
In the current implementation, it happens every 30 min.
So, it's like:
[replica goes high] → make Pods bigger -30m-> make Pods bigger if still high → ...
This PR changes it ignores a replica number higher than PreferredMaxReplicas for the first 30 min so that we can ignore high replica number during a short period of time.
So, it'll be like:
[replica goes high] -30m-> make Pods bigger -30m-> make Pods bigger if still high → ...
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: