New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: record reconciliation failure after ShouldReconcileTortoiseNow #144

Merged

sanposhiho merged 1 commit into main from bugbug

Oct 4, 2023

Collaborator

sanposhiho commented Oct 4, 2023 •

edited

Loading

What this PR does / why we need it:

otherwise all tortoise would't get updated:

ShouldReconcileTortoiseNow says that we cannot update this tortoise now.
defer is executed and UpdateTortoiseStatus in it updates lastTimeUpdateTortoise
In next reconciliation, (1) and (2) would happen again

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:


          fix: record reconciliation failure after ShouldReconcileTortoiseNow

3043ec8

sanposhiho merged commit d7b8f45 into main

3 checks passed

sanposhiho deleted the bugbug branch

October 4, 2023 06:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet