feature: Tortoise goes to beta with some changes (#133)

PROJECT

@@ -1,3 +1,7 @@
+# Code generated by tool. DO NOT EDIT.
+# This file is used to track the info used to scaffold your project
+# and allow the plugins properly work.
+# More info: https://book.kubebuilder.io/reference/project-config.html
 domain: mercari.com
 layout:
 - go.kubebuilder.io/v3
@@ -14,7 +18,19 @@ resources:
   path: github.com/mercari/tortoise/api/v1alpha1
   version: v1alpha1
   webhooks:
+    conversion: true
     defaulting: true
     validation: true
     webhookVersion: v1
+- api:
+    crdVersion: v1
+    namespaced: true
+  domain: mercari.com
+  group: autoscaling
+  kind: Tortoise
+  path: github.com/mercari/tortoise/api/v1beta1
+  version: v1beta1
+  webhooks:
+    conversion: true
+    webhookVersion: v1
 version: "3"

README.md

@@ -30,7 +30,7 @@ Tortoise, you don't need a rearing cage, but need VPA in your Kubernetes cluster
 Tortoise, they only need the deployment name basically.
 
 ```yaml
-apiVersion: autoscaling.mercari.com/v1alpha1
+apiVersion: autoscaling.mercari.com/v1beta1
 kind: Tortoise
 metadata:
   name: lovely-tortoise
@@ -55,7 +55,7 @@ Tortoise, then they'll prepare/keep adjusting HPA and VPA to achieve efficient a
 
 ## API definition
 
-- [Tortoise](./api/v1alpha1/tortoise_types.go)
+- [Tortoise](./api/v1beta1/tortoise_types.go)
 
 ## Contribution
 

api/v1alpha1/tortoise_conversion.go

@@ -0,0 +1,307 @@
+/*
+MIT License
+
+Copyright (c) 2023 mercari
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+
+*/
+
+package v1alpha1
+
+import (
+	"fmt"
+
+	v1 "k8s.io/api/core/v1"
+	"sigs.k8s.io/controller-runtime/pkg/conversion"
+
+	"github.com/mercari/tortoise/api/v1beta1"
+)
+
+// ConvertTo converts this CronJob to the Hub version (v1beta1).
+func (src *Tortoise) ConvertTo(dstRaw conversion.Hub) error {
+	dst := dstRaw.(*v1beta1.Tortoise)
+	dst.ObjectMeta = src.ObjectMeta
+
+	dst.Spec = v1beta1.TortoiseSpec{
+		TargetRefs: v1beta1.TargetRefs{
+			HorizontalPodAutoscalerName: src.Spec.TargetRefs.HorizontalPodAutoscalerName,
+			ScaleTargetRef: v1beta1.CrossVersionObjectReference{
+				APIVersion: "apps/v1",
+				Kind:       "Deployment",
+				Name:       src.Spec.TargetRefs.DeploymentName,
+			},
+		},
+		UpdateMode:     v1beta1.UpdateMode(src.Spec.UpdateMode),
+		ResourcePolicy: containerResourcePolicyConversionToV1Beta1(src.Spec.ResourcePolicy),
+		DeletionPolicy: v1beta1.DeletionPolicy(src.Spec.DeletionPolicy),
+	}
+
+	dst.Status = v1beta1.TortoiseStatus{
+		TortoisePhase: v1beta1.TortoisePhase(src.Status.TortoisePhase),
+		Conditions: v1beta1.Conditions{
+			ContainerRecommendationFromVPA: containerRecommendationFromVPAConversionToV1Beta1(src.Status.Conditions.ContainerRecommendationFromVPA),
+		},
+		Targets: v1beta1.TargetsStatus{
+			HorizontalPodAutoscaler: src.Status.Targets.HorizontalPodAutoscaler,
+			Deployment:              src.Status.Targets.Deployment,
+			VerticalPodAutoscalers:  verticalPodAutoscalersConversionToV1Beta1(src.Status.Targets.VerticalPodAutoscalers),
+		},
+	}
+	if src.Status.Recommendations.Horizontal != nil {
+		dst.Status = v1beta1.TortoiseStatus{
+			Recommendations: v1beta1.Recommendations{
+				Horizontal: v1beta1.HorizontalRecommendations{
+					TargetUtilizations: hPATargetUtilizationRecommendationPerContainerConversionToV1Beta1(src.Status.Recommendations.Horizontal.TargetUtilizations),
+					MaxReplicas:        replicasRecommendationConversionToV1Beta1(src.Status.Recommendations.Horizontal.MaxReplicas),
+					MinReplicas:        replicasRecommendationConversionToV1Beta1(src.Status.Recommendations.Horizontal.MinReplicas),
+				},
+			},
+		}
+	}
+	if src.Status.Recommendations.Vertical != nil {
+		dst.Status = v1beta1.TortoiseStatus{
+			Recommendations: v1beta1.Recommendations{
+				Vertical: v1beta1.VerticalRecommendations{
+					ContainerResourceRecommendation: containerResourceRecommendationConversionToV1Beta1(src.Status.Recommendations.Vertical.ContainerResourceRecommendation),
+				},
+			},
+		}
+	}
+
+	return nil
+}
+
+// ConvertFrom converts from the Hub version (v1beta1) to this version.
+func (dst *Tortoise) ConvertFrom(srcRaw conversion.Hub) error {
+	src := srcRaw.(*v1beta1.Tortoise)
+	if src.Spec.TargetRefs.ScaleTargetRef.Kind != "Deployment" {
+		return fmt.Errorf("scaleTargetRef is not Deployment, but %s which isn't supported in v1alpha1", src.Spec.TargetRefs.ScaleTargetRef.Kind)
+	}
+
+	dst.ObjectMeta = src.ObjectMeta
+	dst.Spec = TortoiseSpec{
+		TargetRefs: TargetRefs{
+			HorizontalPodAutoscalerName: src.Spec.TargetRefs.HorizontalPodAutoscalerName,
+			DeploymentName:              src.Spec.TargetRefs.ScaleTargetRef.Name,
+		},
+		UpdateMode:     UpdateMode(src.Spec.UpdateMode),
+		ResourcePolicy: containerResourcePolicyConversionFromV1Beta1(src.Spec.ResourcePolicy),
+		DeletionPolicy: DeletionPolicy(src.Spec.DeletionPolicy),
+	}
+
+	dst.Status = TortoiseStatus{
+		TortoisePhase: TortoisePhase(src.Status.TortoisePhase),
+		Conditions: Conditions{
+			ContainerRecommendationFromVPA: containerRecommendationFromVPAConversionFromV1Beta1(src.Status.Conditions.ContainerRecommendationFromVPA),
+		},
+		Targets: TargetsStatus{
+			HorizontalPodAutoscaler: src.Status.Targets.HorizontalPodAutoscaler,
+			Deployment:              src.Status.Targets.Deployment,
+			VerticalPodAutoscalers:  verticalPodAutoscalersConversionFromV1Beta1(src.Status.Targets.VerticalPodAutoscalers),
+		},
+		Recommendations: Recommendations{
+			Horizontal: &HorizontalRecommendations{
+				TargetUtilizations: hPATargetUtilizationRecommendationPerContainerConversionFromV1Beta1(src.Status.Recommendations.Horizontal.TargetUtilizations),
+				MaxReplicas:        replicasRecommendationConversionFromV1Beta1(src.Status.Recommendations.Horizontal.MaxReplicas),
+				MinReplicas:        replicasRecommendationConversionFromV1Beta1(src.Status.Recommendations.Horizontal.MinReplicas),
+			},
+			Vertical: &VerticalRecommendations{
+				ContainerResourceRecommendation: containerResourceRecommendationConversionFromV1Beta1(src.Status.Recommendations.Vertical.ContainerResourceRecommendation),
+			},
+		},
+	}
+	return nil
+}
+
+func verticalPodAutoscalersConversionFromV1Beta1(vpas []v1beta1.TargetStatusVerticalPodAutoscaler) []TargetStatusVerticalPodAutoscaler {
+	converted := make([]TargetStatusVerticalPodAutoscaler, 0, len(vpas))
+	for _, vpa := range vpas {
+		converted = append(converted, TargetStatusVerticalPodAutoscaler{
+			Name: vpa.Name,
+			Role: VerticalPodAutoscalerRole(vpa.Role),
+		})
+	}
+	return converted
+}
+
+func verticalPodAutoscalersConversionToV1Beta1(vpas []TargetStatusVerticalPodAutoscaler) []v1beta1.TargetStatusVerticalPodAutoscaler {
+	converted := make([]v1beta1.TargetStatusVerticalPodAutoscaler, 0, len(vpas))
+	for _, vpa := range vpas {
+		converted = append(converted, v1beta1.TargetStatusVerticalPodAutoscaler{
+			Name: vpa.Name,
+			Role: v1beta1.VerticalPodAutoscalerRole(vpa.Role),
+		})
+	}
+	return converted
+}
+
+func containerResourceRecommendationConversionFromV1Beta1(resources []v1beta1.RecommendedContainerResources) []RecommendedContainerResources {
+	converted := make([]RecommendedContainerResources, 0, len(resources))
+	for _, resource := range resources {
+		converted = append(converted, RecommendedContainerResources{
+			ContainerName:       resource.ContainerName,
+			RecommendedResource: resource.RecommendedResource,
+		})
+	}
+	return converted
+}
+
+func containerResourceRecommendationConversionToV1Beta1(resources []RecommendedContainerResources) []v1beta1.RecommendedContainerResources {
+	converted := make([]v1beta1.RecommendedContainerResources, 0, len(resources))
+	for _, resource := range resources {
+		converted = append(converted, v1beta1.RecommendedContainerResources{
+			ContainerName:       resource.ContainerName,
+			RecommendedResource: resource.RecommendedResource,
+		})
+	}
+	return converted
+}
+
+func replicasRecommendationConversionFromV1Beta1(recommendations []v1beta1.ReplicasRecommendation) []ReplicasRecommendation {
+	converted := make([]ReplicasRecommendation, 0, len(recommendations))
+	for _, recommendation := range recommendations {
+		converted = append(converted, ReplicasRecommendation{
+			From:      recommendation.From,
+			To:        recommendation.To,
+			WeekDay:   recommendation.WeekDay,
+			TimeZone:  recommendation.TimeZone,
+			Value:     recommendation.Value,
+			UpdatedAt: recommendation.UpdatedAt,
+		})
+	}
+	return converted
+}
+
+func replicasRecommendationConversionToV1Beta1(recommendations []ReplicasRecommendation) []v1beta1.ReplicasRecommendation {
+	converted := make([]v1beta1.ReplicasRecommendation, 0, len(recommendations))
+	for _, recommendation := range recommendations {
+		converted = append(converted, v1beta1.ReplicasRecommendation{
+			From:      recommendation.From,
+			To:        recommendation.To,
+			WeekDay:   recommendation.WeekDay,
+			TimeZone:  recommendation.TimeZone,
+			Value:     recommendation.Value,
+			UpdatedAt: recommendation.UpdatedAt,
+		})
+	}
+	return converted
+}
+
+func hPATargetUtilizationRecommendationPerContainerConversionFromV1Beta1(recommendations []v1beta1.HPATargetUtilizationRecommendationPerContainer) []HPATargetUtilizationRecommendationPerContainer {
+	converted := make([]HPATargetUtilizationRecommendationPerContainer, 0, len(recommendations))
+	for _, recommendation := range recommendations {
+		converted = append(converted, HPATargetUtilizationRecommendationPerContainer{
+			ContainerName:     recommendation.ContainerName,
+			TargetUtilization: recommendation.TargetUtilization,
+		})
+	}
+	return converted
+}
+
+func hPATargetUtilizationRecommendationPerContainerConversionToV1Beta1(recommendations []HPATargetUtilizationRecommendationPerContainer) []v1beta1.HPATargetUtilizationRecommendationPerContainer {
+	converted := make([]v1beta1.HPATargetUtilizationRecommendationPerContainer, 0, len(recommendations))
+	for _, recommendation := range recommendations {
+		converted = append(converted, v1beta1.HPATargetUtilizationRecommendationPerContainer{
+			ContainerName:     recommendation.ContainerName,
+			TargetUtilization: recommendation.TargetUtilization,
+		})
+	}
+	return converted
+}
+
+func containerRecommendationFromVPAConversionFromV1Beta1(conditions []v1beta1.ContainerRecommendationFromVPA) []ContainerRecommendationFromVPA {
+	converted := make([]ContainerRecommendationFromVPA, 0, len(conditions))
+	for _, condition := range conditions {
+		converted = append(converted, ContainerRecommendationFromVPA{
+			ContainerName:     condition.ContainerName,
+			MaxRecommendation: resourceQuantityMapConversionFromV1Beta1(condition.MaxRecommendation),
+			Recommendation:    resourceQuantityMapConversionFromV1Beta1(condition.Recommendation),
+		})
+	}
+	return converted
+}
+
+func containerRecommendationFromVPAConversionToV1Beta1(conditions []ContainerRecommendationFromVPA) []v1beta1.ContainerRecommendationFromVPA {
+	converted := make([]v1beta1.ContainerRecommendationFromVPA, 0, len(conditions))
+	for _, condition := range conditions {
+		converted = append(converted, v1beta1.ContainerRecommendationFromVPA{
+			ContainerName:     condition.ContainerName,
+			MaxRecommendation: resourceQuantityMapConversionToV1Beta1(condition.MaxRecommendation),
+			Recommendation:    resourceQuantityMapConversionToV1Beta1(condition.Recommendation),
+		})
+	}
+	return converted
+}
+
+func resourceQuantityMapConversionFromV1Beta1(resources map[v1.ResourceName]v1beta1.ResourceQuantity) map[v1.ResourceName]ResourceQuantity {
+	converted := make(map[v1.ResourceName]ResourceQuantity, len(resources))
+	for k, v := range resources {
+		converted[k] = ResourceQuantity(v)
+	}
+	return converted
+}
+
+func resourceQuantityMapConversionToV1Beta1(resources map[v1.ResourceName]ResourceQuantity) map[v1.ResourceName]v1beta1.ResourceQuantity {
+	converted := make(map[v1.ResourceName]v1beta1.ResourceQuantity, len(resources))
+	for k, v := range resources {
+		converted[k] = v1beta1.ResourceQuantity(v)
+	}
+	return converted
+}
+
+func containerResourcePolicyConversionFromV1Beta1(policies []v1beta1.ContainerResourcePolicy) []ContainerResourcePolicy {
+	converted := make([]ContainerResourcePolicy, 0, len(policies))
+	for _, policy := range policies {
+		converted = append(converted, ContainerResourcePolicy{
+			ContainerName:         policy.ContainerName,
+			MinAllocatedResources: policy.MinAllocatedResources,
+			AutoscalingPolicy:     autoscalingPolicyConversionFromV1Beta1(policy.AutoscalingPolicy),
+		})
+	}
+	return converted
+}
+
+func containerResourcePolicyConversionToV1Beta1(policies []ContainerResourcePolicy) []v1beta1.ContainerResourcePolicy {
+	converted := make([]v1beta1.ContainerResourcePolicy, 0, len(policies))
+	for _, policy := range policies {
+		converted = append(converted, v1beta1.ContainerResourcePolicy{
+			ContainerName:         policy.ContainerName,
+			MinAllocatedResources: policy.MinAllocatedResources,
+			AutoscalingPolicy:     autoscalingPolicyConversionToV1Beta1(policy.AutoscalingPolicy),
+		})
+	}
+	return converted
+}
+
+func autoscalingPolicyConversionFromV1Beta1(policies map[v1.ResourceName]v1beta1.AutoscalingType) map[v1.ResourceName]AutoscalingType {
+	converted := make(map[v1.ResourceName]AutoscalingType, len(policies))
+	for k, v := range policies {
+		converted[k] = AutoscalingType(v)
+	}
+	return converted
+}
+
+func autoscalingPolicyConversionToV1Beta1(policies map[v1.ResourceName]AutoscalingType) map[v1.ResourceName]v1beta1.AutoscalingType {
+	converted := make(map[v1.ResourceName]v1beta1.AutoscalingType, len(policies))
+	for k, v := range policies {
+		converted[k] = v1beta1.AutoscalingType(v)
+	}
+	return converted
+}