fix(meow-next-thing): allow no include-syntax #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of `meow-next-thing-include-syntax` (13733e1), `meow--fix-thing-selection-mark` expects to find an entry in this alist corresponding to `thing`. This means that when the user defines their own `thing` and sets `meow-word-thing` or `meow-symbol-thing` to use it, they also need to add a corresponding entry to this alist. I'll admit that I don't understand why the `include-syntax` option needed to be introduced in `meow--fix-thing-selection-mark` (c0878ac). However, my own definitions of `meow-word-thing` and `meow-symbol-thing` worked fine without it. Based on that, my logic in this commit is that users shouldn't have to add to `meow-next-thing-include-syntax` unless they explicitly need the `skip-syntax-*` shrinking that was added to `meow--fix-thing-selection-mark`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of
meow-next-thing-include-syntax(13733e1),meow--fix-thing-selection-markexpects to find an entry in this alist corresponding tothing. This means that when the user defines their ownthingand setsmeow-word-thingormeow-symbol-thingto use it, they also need to add a corresponding entry to this alist.I'll admit that I don't understand why the
include-syntaxoption needed to be introduced inmeow--fix-thing-selection-mark(c0878ac). However, my own definitions ofmeow-word-thingandmeow-symbol-thingworked fine without it. Based on that, my logic in this commit is that users shouldn't have to add tomeow-next-thing-include-syntaxunless they explicitly need theskip-syntax-*shrinking that was added tomeow--fix-thing-selection-mark.