Feat/make initial allocation flexible #361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the allocation configuration more flexible by passing two arrays for recipients and amounts into the mentoToken constructor. The amounts are percentages with 1000 being 100%. I chose 1000 because we currently don't use any decimal position if we want to allow even more e more flexibility if we want to support more precise allocation splits with multiple decimal positions we would need to increase this value.
In the current governanceFactory the addresses for
are automatically added this is done because the governanceFactory deploys these contracts and thereby we can't pass their address into the function. But since the amounts are configurable we can still allocate nothing to them by passing 0 into the createGovernance function.
Other changes
Tested
unit tests
Related issues
Backwards compatibility
Documentation