Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/make initial allocation flexible #361

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

philbow61
Copy link
Contributor

Description

This PR makes the allocation configuration more flexible by passing two arrays for recipients and amounts into the mentoToken constructor. The amounts are percentages with 1000 being 100%. I chose 1000 because we currently don't use any decimal position if we want to allow even more e more flexibility if we want to support more precise allocation splits with multiple decimal positions we would need to increase this value.

In the current governanceFactory the addresses for

  • mentoLabsTreasury
  • airgrab
  • governanceTimelock
    are automatically added this is done because the governanceFactory deploys these contracts and thereby we can't pass their address into the function. But since the amounts are configurable we can still allocate nothing to them by passing 0 into the createGovernance function.

Other changes

Tested

unit tests

Related issues

Backwards compatibility

Documentation

@philbow61 philbow61 changed the base branch from develop to feat/tokenWork January 31, 2024 16:32
Copy link

openzeppelin-code bot commented Jan 31, 2024

Feat/make initial allocation flexible

Generated at commit: 33a4053ff2bcee43fc3cf3c2285f99607569cbf5

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
16
40
59
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@philbow61 philbow61 requested review from a team, chapati23, bowd, bayological and baroooo and removed request for a team, chapati23 and bowd February 1, 2024 11:27
@philbow61 philbow61 merged commit 01dbae9 into feat/tokenWork Feb 1, 2024
1 of 15 checks passed
@philbow61 philbow61 deleted the feat/make-initial-allocation-flexible branch February 1, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Mento token minting parameter an array for initial allocation
3 participants