Governance integration tests #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simpler testing all other related state vars are public so this seems to have been a minor oversight rather than intentional making it private
integration tests will be added in another branch
…ing SARIF report this should not change the fact that CI fails when slither complains. because the SARIF report should contain the same errors which then would make CI fail. But we'd keep the record of issues via SARIF files which currently is not the case.
replaced handmade copy/pasta interfaces with the real code from gnosis
…melocked mentolabs treasury
discussed on discord. we'll start with 0 and can change it later should we want to allow people to buy voting power or delegate votes after a proposal has been submitted.
Governance integration tests
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration tests that cover functionality around new governance and token.
This branch is based on the governance factory branch. Once that is merged all the related changes should be contained in
/test/governance/IntegrationTestsOther changes
Utils.sol and Proposals.sol that is used by the tests
Tested
Yes
Related issues