Fixed Issue #631 #632
Draft
Fixed Issue #631 #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My idea to fix issue #631 is to have a list for vaos (like how textures are handled) that is updated each frame and a new vao is created when a valid one doesn't exist. Therefore, this fixes the problem by creating a vao for each context that doesn't already have one. However, I can see the potential problem that a vao handle that is valid in one context for the correct nvg vao could also be correct in a different context for a different vao. However, to solve this problem would require a major overhaul to the nanovg api. We'd need a way for users to separate shared context state from per-context state and such. Let me know your thoughts and I am open to any ideas.