Maps #9
Open
Maps #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(index > -1){ | ||
| hidden_layers.splice(index,1); | ||
| } | ||
| delete hidden_layers[pkmn]; |
There was a problem hiding this comment.
Please, DON'T
http://stackoverflow.com/a/500617
There was a problem hiding this comment.
Didn't realize that was a thing. I'll revert that.
There was a problem hiding this comment.
How true is this? http://stackoverflow.com/a/8173732
There was a problem hiding this comment.
My fault. I did not see that you've changed hidden_layer from array to object.
delete is fine then.
|
Hi, how do I start this with a mac? I have no idea where to begin ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and working.
Hashing function to not duplicate pokemon required data to change to a dict def eg { }
i feel as this is kinda the best of both worlds. uses your scanning functions and fix the map display issues using luke-jr.
Not sure what branch to pull to so leaving as normal maps.
If you dont want me to push to you just say so.