Problem details production 2 (#1428)

* - Allow exchange besides exc in Groovy and Javascript - More details in script errors * Cleanup * Add method and URI in routing ProblemDetails message
membrane · Dec 19, 2024 · 99fbf50 · 99fbf50
1 parent 248fc2e
commit 99fbf50
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 30 deletions.
diff --git a/README.md b/README.md
@@ -478,27 +478,6 @@ The following example generates a JSON response and sends it directly to the cli
 #### Learn More
 For more details about using JavaScript with Membrane, check the [JavaScript Plugin documentation](https://www.membrane-api.io/docs/current/javascript.html).
 
-### Javascript Extenstion
-
-Besides Groovy you can realize custom behavior with Javascript.
-
-```xml
-<api port="2020">
-        <javascript>
-            console.log("------------ Headers: -------------")
-
-            var fields = header.getAllHeaderFields();
-
-            for(i=0;i &lt; fields.length;i++) {
-              console.log(fields[i]);
-            }
-            CONTINUE
-        </javascript>
-    <target url="https://api.predic8.de"/>
-</api>
-```
-
-
 ## Message Transformation
 
 ### Manipulating HTTP Headers

diff --git a/core/src/main/java/com/predic8/membrane/core/exceptions/ProblemDetails.java b/core/src/main/java/com/predic8/membrane/core/exceptions/ProblemDetails.java
@@ -135,6 +135,8 @@ public Response build() {
                 root.put("message",exception.getMessage());
                 root.put("stackTrace", exception.getStackTrace());
             }
+            root.put("attention", """
+                Membrane is running in development mode. For production set <router production="true"> to reduce the details in error message!""");
             root.putAll(extensions);
         }
 

diff --git a/core/src/main/java/com/predic8/membrane/core/interceptor/RuleMatchingInterceptor.java b/core/src/main/java/com/predic8/membrane/core/interceptor/RuleMatchingInterceptor.java
@@ -46,11 +46,17 @@ public Outcome handleRequest(Exchange exc) throws Exception {
 
 		if (rule instanceof NullRule) {
 			// Do not log. 404 is too common
-			exc.setResponse(ProblemDetails.user(router.isProduction())
-							.statusCode(404)
-							.title("Wrong path or method")
-							.detail("This request was not accepted by Membrane. Please check HTTP method and path.")
-					.build());
+			ProblemDetails pd = ProblemDetails.user(router.isProduction())
+					.statusCode(404)
+					.title("Wrong path or method")
+					.detail("This request was not accepted by Membrane. Please check HTTP method and path.");
+
+			if (!router.isProduction()) {
+				pd.extension("method", exc.getRequest().getMethod());
+				pd.extension("uri", exc.getRequest().getUri());
+			}
+
+			exc.setResponse(pd.build());
 			return ABORT;
 		}
 

diff --git a/core/src/main/java/com/predic8/membrane/core/lang/AbstractScriptInterceptor.java b/core/src/main/java/com/predic8/membrane/core/lang/AbstractScriptInterceptor.java
@@ -132,10 +132,7 @@ protected void handleScriptExecutionException(Exchange exc, Exception e) {
 
         if (!router.isProduction()) {
             pd.extension("message", e.getMessage())
-            .extension("source", trim(src))
-            .extension("note", """
-                To hide error details set Membrane into production mode. In proxies.xml use <router production="true">..</router>.");
-                """);
+            .extension("source", trim(src));
         } else {
             pd.detail("See logs for details.");
         }