Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple DNS zones #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support for multiple DNS zones #55

wants to merge 5 commits into from

Conversation

a0s
Copy link

@a0s a0s commented Jun 22, 2023

Proposed Changes

  1. Update the variables.tf to include a new hostname_tag_name variable.
  2. Modify main.tf to read hostname_tag_name from the variables instead of hardcoding it.
  3. In autoscale.py, change the HOSTNAME_TAG_NAME to read from the os.environ variables.
  4. Expand the README.md with a new section explaining how to use the module with multiple DNS zones.
  5. Updates to support simultaneous updating of both private and public DNS zones.

Description

I have made updates to the terraform-aws-asg-dns-handler project to add support for multiple DNS zones. This includes changes in the Terraform files and Python script, as well as a comprehensive example and explanation added to the README.md file.

Checklist

  • Read the CONTRIBUTING document.
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant