This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Add "overwrite" boolean to allow the possibility to edit a current handle #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to add several method (POST,DELETE,PUT) to an existing handler without headache or having to keep a reference to every handle
|
Hey @adevress, looks good. Would you be able to add some unit tests to https://github.com/meltwater/served/blob/master/src/served/multiplexer.test.cpp? |
Fix potential segmentation fault at destruction
Fix lambda temporary shared_ptr not used (avoid side effects)
Added missing virtual destructor to `segment_matcher`.
- ERROR is a macro in wingdi.h. It can be avoided by defining NOGDI - DELETE is a macro in winnt.h. It has to be undefined
Fix lambda temporary shared_ptr not used (avoid side effects)
explicit on the entire action
shared_ptr explicits
"connection" object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "overwrite" boolean to allow the possibility to edit a current handle instead of creating a new one.
Useful feature when someone want to use multiple method on the same handle without keeping reference to the handle