-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: minimal python project gh repo template #2
Conversation
Add a flake8 config
@aaronsteers updated the instructions with links to the internal-tech-ops repo for getting github apps installed and incase folks need assistance with permissions. |
Co-authored-by: Will Da Silva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'll be stealing most of this for https://github.com/meltano/cron-ext/
Yea, we should definitely propagate this to the EDK as well. If I was smarter I would have set this up before spinning up airflow-ext, superset-ext, and the edk 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting a Pytest config in pyproject.toml
is probably worth doing. This basic one is good to start, and then projects can expand on it based off of what they need. We may want to set up coverage by default too, but that's a bit more difficult since we need to know the name of the thing we're covering.
Co-authored-by: Will Da Silva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
To help with the "Day 2" problem of maintaining existing repos, I think we may want to consider using copier
to install the scaffold for new projects. The long-term benefit is that repos could optionally update/upgrade their scaffold as we change this central one.
Opened for further discussion:
A basic python focused github repo template.
I intialized a basic poetry project so that codeql passes and so that we can ship a basic pytest action.
related to: