Seperation of tool configuration from plugin #86
Conversation
* Updated all EditorJS + react-editor-js to latest versions. * Fixed some missing dependencies. * Fixed URLs for image uploads and link preview. * Re-enabled auth on endpoints.
* Tools are now dynamically loaded from the server, by pointing at a pre-built package on the server. * Added a bunch of types to help making toolpacks easier. * Updated the pluginId resolution to handle scoped packages
|
Hello @xenobytezero ! Thanks for your work. I am using your PR. But unfortunately it does not want to work. I now obtain the This might not even be an issue with your contributions, but since you provided the last updated, I might ask you first. |
|
Hi there, sorry for the delay in getting back to you, crazy work schedules. I didn't add any documentation or anything yet cause I didn't know if it was going to be picked up or anything. The minimal documentation for the tool seperation is that you need to have the default toolpack NPM package installed, either as part of the Strapi install or (probably better) a direct dependency of The code for the default tool pack is at https://github.com/xenobytezero/editorjs-default-toolpack, so will need published seperately. Also the I will look at the link tool now to make sure it is working seperate of the tool seperation. |
|
Also I've pushed a change for the link tool on the other PR |
* Toolpack now recieves the auth token and fetchClient from Strapi * Removed the useDefaultToolpack config option, only the toolpack option is needed
Setup for publishing the forked version
|
That so great. Thank you for your response! |
|
Also I've updated the README.md with a first pass of configuration/toolpack documentaion. Nowhere near complete, but hopefully enough |
|
@melishev Would a merge be possible? |
Having to have a personal git clone of the plugin to just configure/add/remove tools is a little annoying, but understandable considering the nature of Strapi.
This PR creates a seperation of the core plugin code from the tools themselves. The tools are loaded and served from a seperate NPM package, which can be pre-compiled and packaged and then loaded by the client.
On top of the changes in this PR, I've also created a seperate repo which implements the set of tools currently provided by the plugin.
https://github.com/xenobytezero/editorjs-default-toolpack
This is missing documentation so far, but wanted to get a feel for the implementation before I make it more solid.