Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental features spec helper #595

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Jan 11, 2025

Pull Request

What does this PR do?

@ellnix ellnix added skip-changelog The PR will not appear in the release changelogs maintenance Anything related to maintenance (CI, tests, refactoring...) labels Jan 11, 2025
@ellnix ellnix force-pushed the remove-experimental-features-helper branch from 377914d to 72b6a06 Compare January 11, 2025 08:45
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9123ebb) to head (249a1d0).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #595   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          749       754    +5     
=========================================
+ Hits           749       754    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brunoocasali
brunoocasali previously approved these changes Jan 22, 2025
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellnix ellnix force-pushed the remove-experimental-features-helper branch from f07ca62 to 249a1d0 Compare January 22, 2025 07:45
@ellnix
Copy link
Collaborator Author

ellnix commented Jan 22, 2025

@brunoocasali rebased to deal with rubocop, if you could approve again.

@curquiza curquiza requested a review from brunoocasali January 22, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...) skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants