Better stable bytes encode trait #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
better-stable-bytes-encode-trait
branch
from
d7a6598 to
838cec1
Compare
Kerollmops
force-pushed
the
better-stable-bytes-encode-trait
branch
from
838cec1 to
72c23d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We finally found a way to declare the
BytesEncodetrait without making it too much complex and impossible to use in some situation where lifetimes are hard to work with, all of that by keeping the performances, and by only using stable Rust (no nightly feature).The only downside is the fact that structs that implement the BytesEncoder trait will be forces to declare a lifetime if the encoded item (
EItem) requires one, and I am not quite sure that we should always accept?SizedEItemas they are impossible to be used with ranges bounds this is the reason why theStrencoder now accepts a&strand not anstr.It is blocked by #91 and closes #92.