Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Chunking issues with codec #461

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixing Chunking issues with codec #461

wants to merge 1 commit into from

Conversation

edyoshikun
Copy link
Contributor

This fixes #460.

The PR add the option that defaults for max chunk sizes of 500MB or max_chunk_size_bytes in mantis.cli.utils.create_empty_hcs().

Additionally the chunk size is set to Optional=None so that if None, the default chunks are 500MBs.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d31ad91) 9.45% compared to head (2674a42) 9.58%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #461      +/-   ##
========================================
+ Coverage   9.45%   9.58%   +0.13%     
========================================
  Files         29      29              
  Lines       4592    4599       +7     
========================================
+ Hits         434     441       +7     
  Misses      4158    4158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talonchandler
Copy link
Collaborator

Just tested this, and the issue #460 is still present.

This is not yet urgent for @dsundarraman's applications, so let's look at this closer after our deadlines.

@edyoshikun
Copy link
Contributor Author

I looked closer to the issue and I realized that the issue is during the saving of the transfer functions. Here you would have to create_empty_zarr() or add the position.create_zeros() beforehand rather than allocating and saving the 'fov' directly into zarr here @talonchandler

@@ -8,15 +8,18 @@
from iohub.ngff_meta import TransformationMeta
from numpy.typing import DTypeLike

CODEC_MAX_BYTES = 2147483647
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic numbers should either be derived from an expression or accompanied by a comment. For long numbers, the digits should be separated e.g. 2_147_483_647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codec buffer limit error during reconstruction
3 participants