Skip to content

Commit

Permalink
fix(core): add windowsHide for depencies-and-lockfile plugin with bun (
Browse files Browse the repository at this point in the history
…nrwl#26718)

## Current Behavior
Using bun as a package manager on windows causes cmd windows to pop up
when the project graph is computed.

## Expected Behavior
We shouldn't see any windows pop up.

## Related Issue(s)

Fixes nrwl/nx-console#2149
  • Loading branch information
MaxKless authored Jun 27, 2024
1 parent acddf89 commit 0cefa29
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/nx/src/plugins/js/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export const createNodes: CreateNodes = [
? readFileSync(lockFilePath).toString()
: execSync(`bun ${lockFilePath}`, {
maxBuffer: 1024 * 1024 * 10,
windowsHide: true,
}).toString();
const lockFileHash = getLockFileHash(lockFileContents);

Expand Down Expand Up @@ -102,6 +103,7 @@ export const createDependencies: CreateDependencies = (
? readFileSync(lockFilePath).toString()
: execSync(`bun ${lockFilePath}`, {
maxBuffer: 1024 * 1024 * 10,
windowsHide: true,
}).toString();
const lockFileHash = getLockFileHash(lockFileContents);

Expand Down

0 comments on commit 0cefa29

Please sign in to comment.