Remove flags #21
Open
Remove flags #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Signed-off-by: Gordon B. Isnor <[email protected]>
Conflicts: make_flaggable.gemspec
Conflicts: Gemfile make_flaggable.gemspec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to remove flags on an item was a feature that I needed.
I'm doing this by setting unflag = '1' on flaggable, with a before save callback that calls destroy all flaggings if unflag is set, example: https://gist.github.com/gordonbisnor/9ceb1bdaff6748891e2f
Wondered if you would want to merge this into the original project.
Thanks for the great gem!