[ITK] solve itkeigen packaging pb #1113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I put this PR as invalid because after some new tests, there is still a problem with ITKeigen on master, that can be particularly seen in RPM package. Indeed, DEB packages warn that there are linked to weird hardcoded ITKeigen locations in the package (/home/etc), but RPM not only warn but block the installation. ITKeigen is the only ITK ThirdParty module to have this kind of packaging problem, and this could be an ITK bug. For now, one quick solution is to rebuild the RPM removing the problematic lines as explained in this doc. The other solution would be to find a proper debug in ITK and/or medInria, as began here. I'm working on it, if i find something i'll tell here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1111
Itkeigen since ITK5.1.1 had a problem at packaging on Ubuntu at least. It has been discovered during the work of this PR #1112
There were 2 directories at wrong location: include and lib. The include one is solved on line
_eigen3_cmake_install_includedirand the lib one throughITK_INSTALL_PACKAGE_DIR. For the include one we could have usedITK_INSTALL_INCLUDE_DIRbut unfortunately it does not compile because it affects other part of the code.