Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle null when provided to text/textarea/number fields #809

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

chrisvxd
Copy link
Member

@chrisvxd chrisvxd commented Jan 18, 2025

Puck was handling undefined but not null in the DefaultField. This adds stricter typing (which would have caught it), and addresses the underlying issue.

Also does some unrelated tidy up.

Will be released in 0.17.4 (e778246). This implementation if for 0.18.

Closes #775

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 9:48am
puck-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 9:48am

@chrisvxd chrisvxd force-pushed the 775-null-value-handling branch from 305f531 to 7893e28 Compare January 18, 2025 09:40
@chrisvxd chrisvxd enabled auto-merge (rebase) January 18, 2025 10:05
@chrisvxd chrisvxd disabled auto-merge January 18, 2025 10:06
@chrisvxd chrisvxd merged commit df3d1c2 into main Jan 18, 2025
4 checks passed
@chrisvxd chrisvxd deleted the 775-null-value-handling branch January 18, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null value is not handled in ObjectField
1 participant