Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style clashing with dark mode root element #107

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

gothfemme
Copy link
Contributor

  • Adds in styles so Puck doesn't inherit styles from the document body.
  • Fixes an issue where the preview root would inherit/be blocked by the editor frame.
    • I'm just faking the frame with a box shadow.
  • Fixes an issue where horizontal scrollbars were always visible for SidebarSection's even when not overflowing.
  • Closes Radix and Puck styles clashing #106

@vercel
Copy link

vercel bot commented Sep 24, 2023

@gothfemme is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

@gothfemme
Copy link
Contributor Author

gothfemme commented Sep 24, 2023

I kept the styles in Puck/index.tsx as inline rather than creating a new file for it as I imagine that's outside the scope of this ticket, but let me know and I can do that if necessary.

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 1:38pm

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent stuff @gothfemme! Left a couple of comments.

Updating the inline styles is definitely the right place for now. These really need to get pulled out at some point.

packages/core/components/Puck/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🚀

@chrisvxd chrisvxd merged commit 87c8736 into measuredco:main Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radix and Puck styles clashing
2 participants