Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-230 | Overview - Quick Transport & Stats list refactor #236

Merged
merged 3 commits into from
Jul 7, 2022
Merged

GH-230 | Overview - Quick Transport & Stats list refactor #236

merged 3 commits into from
Jul 7, 2022

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Jul 7, 2022

Summary:

Overview screen has a lot of components that should have their own (sub)modules, let's refactor this.

Changelog:

  • Move Quick transport's code to its own component
  • Quick transport should use existing functions related to resources
  • Move Stats List's code to its own component
  • Don't repeat code for each stats category, use loop to render all categories

Related issues or PRs:

#230

@mdziekon mdziekon added the pr:refactor All pull requests containing code refactors label Jul 7, 2022
@mdziekon mdziekon merged commit b20e0a2 into master Jul 7, 2022
@mdziekon mdziekon deleted the gh-230-res-transport-component branch July 7, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:refactor All pull requests containing code refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdziekon