Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few typos I spotted while reading the paper #178

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

hugoledoux
Copy link

I'm your JOSS editor, in case you don't recognise me :)

Copy link

welcome bot commented Mar 7, 2024

💖 Thanks for opening this pull request! 💖
Please make sure you read our contributing guidelines.
A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it. * All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code. * No matter what, we are really grateful that you put in the effort to do this! 🎉

@mdtanker mdtanker changed the title A few typos I spotted while reading the paper docs: A few typos I spotted while reading the paper Mar 9, 2024
@mdtanker mdtanker changed the title docs: A few typos I spotted while reading the paper A few typos I spotted while reading the paper Mar 9, 2024
Copy link
Owner

@mdtanker mdtanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching those!

@mdtanker mdtanker merged commit 4b186ff into mdtanker:JOSS_paper Mar 9, 2024
3 of 13 checks passed
Copy link

welcome bot commented Mar 9, 2024

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉
We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@mdtanker
Copy link
Owner

Sorry I'm not exactly sure what happened, but I completely messed up the PR JOSS_paper and ended up having to manually add your corrections with a new commit. Should all be sorted now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants