Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Improve package management #147

Closed
wants to merge 5 commits into from
Closed

Improve package management #147

wants to merge 5 commits into from

Conversation

kamaradclimber
Copy link
Contributor

@kamaradclimber kamaradclimber commented Jul 25, 2017 •
edited
Loading

This patch improves package management:

  • it stop using dynamic version computation for rhel. This creates non-deterministc behavior
  • it allows to pass options to package (convenient when using custom repositories for instance)

cc @criteo-cookbooks/sre-core

pierrecdn and others added 3 commits May 12, 2017 11:21
@pierrecdn
Do not use dynamic version from Yum provider
2cad4b7
@kamaradclimber
Allow to specify package options
4125800 
Change-Id: I16720af4e42270cfcd2d20a990fd98773616440c
@kamaradclimber
Support passing option to package on rhel as well
f74a987 
Change-Id: I3343e2ad18f24a1550c906a0b8a017986dce533a
@rveznaver
Copy link
Collaborator

Please elaborate on point (1). AFAIK, due to a missing feature in the yum package provider, it behaves differently from dpkg (the version must be specified fully, it does not support wildcards for the release part). Has this been fixed in a recent Chef version? If so, which one?

Also, please fix tests in Travis.

@kamaradclimber
Copy link
Contributor Author

Thanks for the feedback.

un-deterministic behavior comes from the fact that dynamic version will upgrade mesos package to latest version available (instead of offering full control to user via attributes).
Indeed yum_package resource does not offer the same level of customization as apt_package (but this is a behavior of apt itself).

I'll have a look at travis

@kamaradclimber
Correct foodcritic errors
4dc6e5c 
Change-Id: Id264eee583997135da49963f9a7c089b00d866e8
@kamaradclimber
Lint using rubocop
393edb8 
- constrain targetrubyversion to avoid discrepencies between builds
- apply rubocop -a

Change-Id: I15094861c023fe6e921676753578fee55be807a4
@kamaradclimber
Copy link
Contributor Author

fixed all issues @rveznaver :)

@kamaradclimber
Copy link
Contributor Author

any news @rveznaver ?

@rveznaver
Copy link
Collaborator

I have yet to review and test this change. Should have some time next week. Sry.

@kamaradclimber
Copy link
Contributor Author

Any news @rveznaver ?

@clems4ever
Copy link

I also had a look at it and it looks good to me!

@kamaradclimber
Copy link
Contributor Author

closing since #149 has no answer at all

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamaradclimber @rveznaver @clems4ever @pierrecdn