Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): measure "Add/edit note" on collection items #9850

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 19, 2023

Summary

(MP-603)

Problem

We don't know how many users click on "Add note" or "Edit note" on the Collections page.

Solution

Add measurements.

Note: Also groups all Collections-related telemetry constants into a PLUS_COLLECTIONS object.


How did you test this change?

Ran yarn && yarn dev with the following environment variables (in .env):

REACT_APP_GLEAN_DEBUG=true
REACT_APP_GLEAN_ENABLED=true

Then visited http://localhost:3000/en-US/plus/collections with a local Rumba and clicked on "Add note" and "Edit note" respectively.

@caugner caugner requested a review from a team October 19, 2023 10:02
@github-actions github-actions bot added plus work around features related to MDN Plus metrics labels Oct 19, 2023
@caugner caugner marked this pull request as ready for review October 19, 2023 11:19
@LeoMcA LeoMcA self-assigned this Oct 19, 2023
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested, but I trust your testing - code changes look good

@caugner caugner merged commit 47d3686 into main Oct 19, 2023
@caugner caugner deleted the measure-collections-add-note-clicks branch October 19, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants