Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blog): type buildBlog() param type #9830

Merged
merged 3 commits into from
Oct 27, 2023
Merged

chore(blog): type buildBlog() param type #9830

merged 3 commits into from
Oct 27, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 17, 2023 •
edited
Loading

Summary

(MP-378)

Problem

The buildBlog() function had an untyped parameter document.

Solution

Add a new BlogPostDoc type for it.

Also removes setting the modified property, because it is always null and never used.

How did you test this change?

@caugner caugner requested a review from a team October 17, 2023 11:12
@caugner caugner marked this pull request as ready for review October 18, 2023 12:16
@caugner caugner merged commit 55d9d83 into main Oct 27, 2023
12 checks passed
@caugner caugner deleted the add-buildPost-param-type branch October 27, 2023 10:38
@github-actions github-actions bot mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @fiji-flo