Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(build): avoid race condition in destructive test #9828

Merged
merged 2 commits into from
Oct 30, 2023
Merged

test(build): avoid race condition in destructive test #9828

merged 2 commits into from
Oct 30, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 16, 2023 •
edited
Loading

Summary

Problem

The destructive.test.ts is flaky and regularly fails, because files are checked in a non-deterministic order.

Solution

Make the test more resilient by making the assertions independent from the order certain file paths appear in the output.

How did you test this change?

Tests are passing.

@caugner caugner force-pushed the stabilize-flaky-test branch from 8e4edc6 to 8fec580 Compare October 17, 2023 09:25
@caugner caugner changed the title test(build): avoid race condition test(build): avoid race condition in destructive test Oct 17, 2023
@caugner caugner requested a review from a team October 17, 2023 09:26
@caugner caugner marked this pull request as ready for review October 18, 2023 12:12
@caugner caugner added p2 We want to address this but may have other higher priority items. dx developer experience labels Oct 27, 2023
fiji-flo
fiji-flo approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Look good.

@caugner caugner merged commit 1f11e2c into main Oct 30, 2023
13 checks passed
@caugner caugner deleted the stabilize-flaky-test branch October 30, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
dx developer experience p2 We want to address this but may have other higher priority items.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @fiji-flo