enhance(libs/env): improve error message for bad .env configs #9673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If there is a bad configuration in
.env
file then build throws following error:This is very hard to debug because the error message doesn't give any details. The error is not in any
.json
file. And.env
is not tracked using git so the changes don't show up in diffs.Solution
Wrap
JSON.parse
in a function to throw an error with better message.Following are the logs after the fix:
How did you test this change?
Ran
yarn tool optimize-client-build
before and after the fix.