refactor(client): load more lazily #10143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
Reduces the main bundle significantly: - main.js: 156.44 kB -> 128.77 kB (- 18 %) - main.css: 28.42 kB -> 21.99 kB (- 17 %)
This reverts commit 5e91e29.
caugner
force-pushed
the
reduce-bundle-size
branch
from
895b0c5 to
3f8bba5
Compare
github-actions
bot
removed
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
merge conflicts 🚧
|
Lazy-loading impacts SSR, so closing for now, see also: #11048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Our main bundle is larger than it could be.
Solution
Load more pages lazily.
Screenshots
Before
After
How did you test this change?
Ran
yarn build:client.